Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - bevy_ui: Check clip when handling interactions #3461

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - bevy_ui: Check clip when handling interactions #3461

wants to merge 1 commit into from

Conversation

Davier
Copy link
Contributor

@Davier Davier commented Dec 28, 2021

Objective

Fix a bug: UI nodes that are clipped could still be interacted with in the clipped area.

Solution

Clip the position calculation in ui_focus_system

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 28, 2021
@alice-i-cecile alice-i-cecile added A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior and removed S-Needs-Triage This issue needs to be labelled labels Dec 28, 2021
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 28, 2021
@cart
Copy link
Member

cart commented Dec 28, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 28, 2021
@Davier
bevy_ui: Check clip when handling interactions (#3461)
601cc0c 
# Objective

Fix a bug: UI nodes that are clipped could still be interacted with in the clipped area.

## Solution

Clip the position calculation in `ui_focus_system`
@bors
Copy link
Contributor

bors bot commented Dec 28, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title bevy_ui: Check clip when handling interactions [Merged by Bors] - bevy_ui: Check clip when handling interactions Dec 28, 2021
@bors bors bot closed this Dec 28, 2021
@Davier Davier deleted the ui_clip_interactions branch December 28, 2021 21:01
mockersf pushed a commit to mockersf/bevy that referenced this pull request Jan 1, 2022
@Davier @mockersf
bevy_ui: Check clip when handling interactions (bevyengine#3461)
b0c8786 
# Objective

Fix a bug: UI nodes that are clipped could still be interacted with in the clipped area.

## Solution

Clip the position calculation in `ui_focus_system`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Davier @cart @alice-i-cecile