Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - load spirv using correct API #3466

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - load spirv using correct API #3466

wants to merge 3 commits into from

Conversation

molikto
Copy link
Contributor

@molikto molikto commented Dec 29, 2021

Objective

currently spirv source loading parse then desterilize it to make wgpu happy.

Solution

Use the right API to get spirv

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 29, 2021
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change and removed S-Needs-Triage This issue needs to be labelled labels Dec 29, 2021
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 30, 2021
@cart
Copy link
Member

cart commented Dec 30, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 30, 2021
@molikto
load spirv using correct API (#3466)
3ac55f0 
# Objective

currently spirv source loading parse then desterilize it to make wgpu happy.

## Solution

Use the right API to get spirv
@bors
Copy link
Contributor

bors bot commented Dec 30, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title load spirv using correct API [Merged by Bors] - load spirv using correct API Dec 30, 2021
@bors bors bot closed this Dec 30, 2021
mockersf pushed a commit to mockersf/bevy that referenced this pull request Jan 1, 2022
@molikto @mockersf
load spirv using correct API (bevyengine#3466)
e463d9c 
# Objective

currently spirv source loading parse then desterilize it to make wgpu happy.

## Solution

Use the right API to get spirv
@molikto molikto deleted the load-spirv branch April 17, 2022 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@molikto @cart @alice-i-cecile @mockersf @bjorn3