[Merged by Bors] - iter_mut on Assets: send modified event only when asset is iterated over
#3565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
added
A-Assets
alice-i-cecile
approved these changes
Jan 6, 2022
james7132
approved these changes
Mar 3, 2022
james7132
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 5, 2022
… over (#3565) # Objective - `Assets<T>::iter_mut` sends `Modified` event for all assets first, then returns the iterator - This means that events could be sent for assets that would not have been mutated if iteration was stopped before ## Solution - Send `Modified` event when assets are iterated over. Co-authored-by: François <8672791+mockersf@users.noreply.github.com>
bors
bot
changed the title
iter_mut on Assets: send modified event only when asset is iterated overiter_mut on Assets: send modified event only when asset is iterated over
kurtkuehnert
pushed a commit
to kurtkuehnert/bevy
that referenced
this pull request
Mar 6, 2022
… over (bevyengine#3565) # Objective - `Assets<T>::iter_mut` sends `Modified` event for all assets first, then returns the iterator - This means that events could be sent for assets that would not have been mutated if iteration was stopped before ## Solution - Send `Modified` event when assets are iterated over. Co-authored-by: François <8672791+mockersf@users.noreply.github.com>
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
… over (bevyengine#3565) # Objective - `Assets<T>::iter_mut` sends `Modified` event for all assets first, then returns the iterator - This means that events could be sent for assets that would not have been mutated if iteration was stopped before ## Solution - Send `Modified` event when assets are iterated over. Co-authored-by: François <8672791+mockersf@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Assets<T>::iter_mutsendsModifiedevent for all assets first, then returns the iteratorSolution
Modifiedevent when assets are iterated over.