Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix despawn #361

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Fix despawn #361

merged 2 commits into from
Aug 27, 2020

Conversation

cart
Copy link
Member

@cart cart commented Aug 27, 2020

Properly tracks added and removed RenderResources in RenderResourcesNode. This also refactors how gpu arrays are managed to improve clarity.

This also should open the door to using ECS changing tracking here, which should be a pretty major perf boost for objects that don't move all of the time.

Fixes #299

@ncallaway
Copy link
Contributor

#328 (very likely a duplicate of 299) is also resolved by this.

@hollg
Copy link

hollg commented Aug 27, 2020

Can confirm this fixes the problem I reported in #299

@cart cart merged commit 89a1d36 into bevyengine:master Aug 27, 2020
@karroffel karroffel added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events A-Rendering Drawing game state to the screen labels Aug 27, 2020
@sim-the-bean sim-the-bean mentioned this pull request Sep 2, 2020
mrk-its pushed a commit to mrk-its/bevy that referenced this pull request Oct 6, 2020
* simplify RenderResourcesNode gpu array management

* support removals in RenderResourcesNode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sprites disappearing in 0.1.3
4 participants