Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target directory for sub-crates to gitignore #372

Merged
merged 2 commits into from
Aug 27, 2020

Conversation

Xavientois
Copy link
Contributor

Small addition to the .gitignore that it makes sense to have, since all target directories should be ignored as a general rule.

@AngelOnFira
Copy link
Contributor

I think it would be better to just change the /target line to `**/target/?

@Xavientois
Copy link
Contributor Author

I thought of that, but I wasn't sure if there was the possibility, now or in the future, of some regular directory being named target as well. I tend to err on the side of caution when it comes to my .gitignores and not ignoring something unless I am certain to never want to include it

@cart
Copy link
Member

cart commented Aug 27, 2020

I'm sold. Thanks!

@cart cart merged commit 63fd4ae into bevyengine:master Aug 27, 2020
mrk-its pushed a commit to mrk-its/bevy that referenced this pull request Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants