Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix custom material glsl example using incorrect CameraViewProj #3962

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix custom material glsl example using incorrect CameraViewProj #3962

wants to merge 1 commit into from

Conversation

mcobzarenco
Copy link
Contributor

Objective

The custom_material.vert shader used by the shader_material_glsl example is missing a mat4 View in CameraViewProj (added in #3885)

Solution

Update the definition of CameraViewProj

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Feb 16, 2022
@cart
Copy link
Member

cart commented Feb 16, 2022

bors r+

bors bot pushed a commit that referenced this pull request Feb 16, 2022
@mcobzarenco
Fix custom material glsl example using incorrect CameraViewProj (#3962)
b0768a5 
# Objective

The `custom_material.vert` shader used by the `shader_material_glsl` example is missing a `mat4 View` in `CameraViewProj` (added in [#3885](#3885))

## Solution

Update the definition of `CameraViewProj`
@bors
Copy link
Contributor

bors bot commented Feb 16, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix custom material glsl example using incorrect CameraViewProj [Merged by Bors] - Fix custom material glsl example using incorrect CameraViewProj Feb 16, 2022
@bors bors bot closed this Feb 16, 2022
@mockersf mockersf added C-Examples An addition or correction to our examples and removed S-Needs-Triage This issue needs to be labelled labels Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-Examples An addition or correction to our examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcobzarenco @cart @mockersf