Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Make get_resource (and friends) infallible #4047

Closed
wants to merge 17 commits into from
Closed

[Merged by Bors] - Make get_resource (and friends) infallible #4047

wants to merge 17 commits into from

Commits on Feb 26, 2022

  1. Updated docs

    @alice-i-cecile
    alice-i-cecile committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    29c9ea3 View commit details
    Browse the repository at this point in the history

  2. Try get resource methods

    @alice-i-cecile
    alice-i-cecile committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    96463a6 View commit details
    Browse the repository at this point in the history

  3. Update usages of .get_resource

    @alice-i-cecile
    alice-i-cecile committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    c8294af View commit details
    Browse the repository at this point in the history

  4. Remove pointless WorldCell

    @alice-i-cecile
    alice-i-cecile committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    6a603f7 View commit details
    Browse the repository at this point in the history

  5. Finish updating usages of .get_resources

    @alice-i-cecile
    alice-i-cecile committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    7b4eb3d View commit details
    Browse the repository at this point in the history

  6. More helpful error messages

    @alice-i-cecile
    alice-i-cecile committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    0bd5bdb View commit details
    Browse the repository at this point in the history

  7. Change get_non_send_resource behavior to match

    @alice-i-cecile
    alice-i-cecile committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    69b82c2 View commit details
    Browse the repository at this point in the history

  8. Remove unwrap in test

    @alice-i-cecile
    alice-i-cecile committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    08aa672 View commit details
    Browse the repository at this point in the history

  9. Nits from code review 

    Co-authored-by: KDecay <KDecayMusic@protonmail.com>
    @alice-i-cecile
    alice-i-cecile and KDecay committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    2550ec3 View commit details
    Browse the repository at this point in the history

  10. Remove more unwraps from examples

    @alice-i-cecile
    alice-i-cecile committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    b7f0af7 View commit details
    Browse the repository at this point in the history

  11. Unwraps in macro...

    @alice-i-cecile
    alice-i-cecile committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    a39d895 View commit details
    Browse the repository at this point in the history

  12. Rename methods to match convention

    @alice-i-cecile
    alice-i-cecile committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    74f50a3 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2022

  1. Move stray safety comment

    @alice-i-cecile
    alice-i-cecile committed Feb 27, 2022
    Configuration menu
    Copy the full SHA
    5444ff0 View commit details
    Browse the repository at this point in the history

  2. Fix assorted compilation errors and tests

    @alice-i-cecile
    alice-i-cecile committed Feb 27, 2022
    Configuration menu
    Copy the full SHA
    5aa4b48 View commit details
    Browse the repository at this point in the history

  3. Remove expect in example

    @alice-i-cecile
    alice-i-cecile committed Feb 27, 2022
    Configuration menu
    Copy the full SHA
    3f3b495 View commit details
    Browse the repository at this point in the history

  4. Improve error messages

    @alice-i-cecile
    alice-i-cecile committed Feb 27, 2022
    Configuration menu
    Copy the full SHA
    d63c760 View commit details
    Browse the repository at this point in the history

  5. Use #[track_caller] 

    Co-authored-by: MinerSebas <66798382+MinerSebas@users.noreply.github.com>
    @alice-i-cecile @MinerSebas
    alice-i-cecile and MinerSebas committed Feb 27, 2022
    Configuration menu
    Copy the full SHA
    d36944d View commit details
    Browse the repository at this point in the history