[Merged by Bors] - bevy_reflect: IntoIter for DynamicList and DynamicMap
#4108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
added
A-Reflection
|
Not sure why CI failed. Fixed an unrelated issue using |
|
CI error was due to a network error and should be ignored, no need to fix the markdown in this PR 👍 |
Ah, makes sense. I'll revert. |
mockersf
approved these changes
Mar 5, 2022
james7132
approved these changes
Mar 5, 2022
james7132
added
the
S-Ready-For-Final-Review
MrGVSV
changed the title
IntoIter for DynamicList and DynamicMapIntoIter for DynamicList and DynamicMap
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 25, 2022
# Objective In some cases, you may want to take ownership of the values in `DynamicList` or `DynamicMap`. I came across this need while trying to implement a custom deserializer, but couldn't get ownership of the values in the list. ## Solution Implemented `IntoIter` for both `DynamicList` and `DynamicMap`.
|
Build failed (retrying...): |
|
@MrGVSV looks like this needs to be reformatted. |
|
bors r- |
|
Canceled. |
@alice-i-cecile I just did a quick |
|
Okay 🤔 Well, let's try again. If this fails, I think you should try rebasing. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 25, 2022
# Objective In some cases, you may want to take ownership of the values in `DynamicList` or `DynamicMap`. I came across this need while trying to implement a custom deserializer, but couldn't get ownership of the values in the list. ## Solution Implemented `IntoIter` for both `DynamicList` and `DynamicMap`.
|
Timed out. |
1 similar comment
|
Timed out. |
|
Hm, okay I'll try a rebase then. |
MrGVSV
force-pushed
the
reflect-into-iter
branch
from
92fe460
to
3608a81
Compare
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 25, 2022
# Objective In some cases, you may want to take ownership of the values in `DynamicList` or `DynamicMap`. I came across this need while trying to implement a custom deserializer, but couldn't get ownership of the values in the list. ## Solution Implemented `IntoIter` for both `DynamicList` and `DynamicMap`.
|
Build failed: |
|
@MrGVSV looks like you got bitten by a rebase and accidentally changed CONTRIBUTING.md. Can you revert that? |
MrGVSV
force-pushed
the
reflect-into-iter
branch
from
3608a81
to
6c5af23
Compare
Sorry about that (you can tell I don't rebase much haha) |
|
No worries; git can be a real pain at times. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 26, 2022
# Objective In some cases, you may want to take ownership of the values in `DynamicList` or `DynamicMap`. I came across this need while trying to implement a custom deserializer, but couldn't get ownership of the values in the list. ## Solution Implemented `IntoIter` for both `DynamicList` and `DynamicMap`.
bors
bot
changed the title
IntoIter for DynamicList and DynamicMapIntoIter for DynamicList and DynamicMap
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
…ne#4108) # Objective In some cases, you may want to take ownership of the values in `DynamicList` or `DynamicMap`. I came across this need while trying to implement a custom deserializer, but couldn't get ownership of the values in the list. ## Solution Implemented `IntoIter` for both `DynamicList` and `DynamicMap`.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…ne#4108) # Objective In some cases, you may want to take ownership of the values in `DynamicList` or `DynamicMap`. I came across this need while trying to implement a custom deserializer, but couldn't get ownership of the values in the list. ## Solution Implemented `IntoIter` for both `DynamicList` and `DynamicMap`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
In some cases, you may want to take ownership of the values in
DynamicListorDynamicMap.I came across this need while trying to implement a custom deserializer, but couldn't get ownership of the values in the list.
Solution
Implemented
IntoIterfor bothDynamicListandDynamicMap.