Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize transform systems to only run on change #417

Merged
merged 2 commits into from
Sep 6, 2020
Merged

Optimize transform systems to only run on change #417

merged 2 commits into from
Sep 6, 2020

Conversation

tristanpemble
Copy link
Contributor

Partially implements #63. I'm aware that there is some work being done to rewrite transforms in #229 and #374, but this was an easy way to get my feet wet and could potentially serve as an example for more work in #63. It's also unclear what the timeline for that is.

This is the first Rust contribution I've ever made, so undoubtedly I have made a mistake somehow.

This PR also adds Or to the prelude, which I can move to a separate PR if you like.

@CleanCut
Copy link
Member

CleanCut commented Sep 2, 2020

Welcome! That's quite a hefty change to make for your first Rust contribution!

Looks like rustfmt wants to heavily reformat your code. Running cargo +nightly fmt --all and then committing and pushing the result should get you past that particular CI job.

@Moxinilian Moxinilian added C-Enhancement A new feature C-Performance A change motivated by improving speed, memory usage or compile times labels Sep 2, 2020
@cart
Copy link
Member

cart commented Sep 6, 2020

Looks perfect to me. Thanks!

@cart cart merged commit 43463a7 into bevyengine:master Sep 6, 2020
@tristanpemble tristanpemble deleted the transform-on-changed branch September 9, 2020 07:32
mrk-its pushed a commit to mrk-its/bevy that referenced this pull request Oct 6, 2020
Optimize transform systems to only run on change
@DJMcNab
Copy link
Member

DJMcNab commented Jul 6, 2021

@tristanpemble please respond in #2373 for the relicense to MIT/Apache 2.0. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Enhancement A new feature C-Performance A change motivated by improving speed, memory usage or compile times
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants