Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - add benches for simple run criteria #4196

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - add benches for simple run criteria #4196

wants to merge 1 commit into from

Conversation

hymm
Copy link
Contributor

@hymm hymm commented Mar 13, 2022 •
edited
Loading

Objective

  • Add benches for run criteria. This is in anticipation of run criteria being redone in stageless.

Solution

  • Benches run criteria that don't access anything to test overhead
  • Test run criteria that use a query
  • Test run criteria that use a resource

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Mar 13, 2022
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Performance A change motivated by improving speed, memory usage or compile times and removed S-Needs-Triage This issue needs to be labelled labels Mar 13, 2022
alice-i-cecile
alice-i-cecile approved these changes Mar 13, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful, code LGTM.

@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 16, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Apr 26, 2022
@hymm
add benches for simple run criteria (#4196)
d012e30 
# Objective

- Add benches for run criteria. This is in anticipation of run criteria being redone in stageless.

## Solution

- Benches run criteria that don't access anything to test overhead
- Test run criteria that use a query
- Test run criteria that use a resource
@bors
Copy link
Contributor

bors bot commented Apr 26, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Apr 26, 2022
@hymm
add benches for simple run criteria (#4196)
45d2c78 
# Objective

- Add benches for run criteria. This is in anticipation of run criteria being redone in stageless.

## Solution

- Benches run criteria that don't access anything to test overhead
- Test run criteria that use a query
- Test run criteria that use a resource
@bors
Copy link
Contributor

bors bot commented Apr 26, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title add benches for simple run criteria [Merged by Bors] - add benches for simple run criteria Apr 26, 2022
@bors bors bot closed this Apr 26, 2022
@hymm hymm deleted the more-scheduler-benches branch May 10, 2022 22:52
exjam pushed a commit to exjam/bevy that referenced this pull request May 22, 2022
@hymm @exjam
add benches for simple run criteria (bevyengine#4196)
354cfc0 
# Objective

- Add benches for run criteria. This is in anticipation of run criteria being redone in stageless.

## Solution

- Benches run criteria that don't access anything to test overhead
- Test run criteria that use a query
- Test run criteria that use a resource
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@hymm @ItsDoot
add benches for simple run criteria (bevyengine#4196)
95df7c1 
# Objective

- Add benches for run criteria. This is in anticipation of run criteria being redone in stageless.

## Solution

- Benches run criteria that don't access anything to test overhead
- Test run criteria that use a query
- Test run criteria that use a resource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Performance A change motivated by improving speed, memory usage or compile times S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Scheduling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hymm @alice-i-cecile @james7132