[Merged by Bors] - Improve docs and naming for RawWindowHandle functionality #4335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Windowing
|
Pulling in @cart directly for a review here as the original author of the code. I'm reasonably confident that I understand the logic behind the design now, but this is tricksy unsafe logic. |
alice-i-cecile
commented
Mar 26, 2022
nicopap
suggested changes
Apr 25, 2022
Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
nicopap
approved these changes
Apr 25, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 25, 2022
# Objective - As noticed in #4333 by @x-52, the exact purpose and logic of `HasRawWIndowHandleWrapper` is unclear - Unfortunately, there are rather good reasons why this design is needed (and why we can't just `impl HasRawWindowHandle for RawWindowHandleWrapper` ## Solution - Rename `HasRawWindowHandleWrapper` to `ThreadLockedRawWindowHandleWrapper`, reflecting the primary distinction - Document how this design is intended to be used - Leave comments explaining why this design must exist ## Migration Guide - renamed `HasRawWindowHandleWrapper` to `ThreadLockedRawWindowHandleWrapper`
|
Build failed: |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 26, 2022
# Objective - As noticed in #4333 by @x-52, the exact purpose and logic of `HasRawWIndowHandleWrapper` is unclear - Unfortunately, there are rather good reasons why this design is needed (and why we can't just `impl HasRawWindowHandle for RawWindowHandleWrapper` ## Solution - Rename `HasRawWindowHandleWrapper` to `ThreadLockedRawWindowHandleWrapper`, reflecting the primary distinction - Document how this design is intended to be used - Leave comments explaining why this design must exist ## Migration Guide - renamed `HasRawWindowHandleWrapper` to `ThreadLockedRawWindowHandleWrapper`
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Jun 7, 2022
…#4335) # Objective - As noticed in bevyengine#4333 by @x-52, the exact purpose and logic of `HasRawWIndowHandleWrapper` is unclear - Unfortunately, there are rather good reasons why this design is needed (and why we can't just `impl HasRawWindowHandle for RawWindowHandleWrapper` ## Solution - Rename `HasRawWindowHandleWrapper` to `ThreadLockedRawWindowHandleWrapper`, reflecting the primary distinction - Document how this design is intended to be used - Leave comments explaining why this design must exist ## Migration Guide - renamed `HasRawWindowHandleWrapper` to `ThreadLockedRawWindowHandleWrapper`
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…#4335) # Objective - As noticed in bevyengine#4333 by @x-52, the exact purpose and logic of `HasRawWIndowHandleWrapper` is unclear - Unfortunately, there are rather good reasons why this design is needed (and why we can't just `impl HasRawWindowHandle for RawWindowHandleWrapper` ## Solution - Rename `HasRawWindowHandleWrapper` to `ThreadLockedRawWindowHandleWrapper`, reflecting the primary distinction - Document how this design is intended to be used - Leave comments explaining why this design must exist ## Migration Guide - renamed `HasRawWindowHandleWrapper` to `ThreadLockedRawWindowHandleWrapper`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy_window#4333 by @x-52, the exact purpose and logic ofHasRawWIndowHandleWrapperis unclearimpl HasRawWindowHandle for RawWindowHandleWrapperSolution
HasRawWindowHandleWrappertoThreadLockedRawWindowHandleWrapper, reflecting the primary distinctionMigration Guide
HasRawWindowHandleWrappertoThreadLockedRawWindowHandleWrapper