Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Clean up duplicated color conversion code #4360

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Clean up duplicated color conversion code #4360

wants to merge 1 commit into from

Conversation

rparrett
Copy link
Contributor

Objective

Cleans up some duplicated color -> u32 conversion code in bevy_sprite and bevy_ui

Solution

Use as_linear_rgba_u32 which was added recently by #4088

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Mar 29, 2022
@mockersf mockersf added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change and removed S-Needs-Triage This issue needs to be labelled labels Mar 29, 2022
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 29, 2022
@cart
Copy link
Member

cart commented Mar 29, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 29, 2022
@rparrett
Clean up duplicated color conversion code (#4360)
7ff3d87 
# Objective

Cleans up some duplicated color -> u32 conversion code in `bevy_sprite` and `bevy_ui`

## Solution

Use `as_linear_rgba_u32` which was added recently by #4088
@bors
Copy link
Contributor

bors bot commented Mar 29, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Clean up duplicated color conversion code [Merged by Bors] - Clean up duplicated color conversion code Mar 29, 2022
@bors bors bot closed this Mar 29, 2022
aevyrie pushed a commit to aevyrie/bevy that referenced this pull request Jun 7, 2022
@rparrett @aevyrie
Clean up duplicated color conversion code (bevyengine#4360)
08c08e4 
# Objective

Cleans up some duplicated color -> u32 conversion code in `bevy_sprite` and `bevy_ui`

## Solution

Use `as_linear_rgba_u32` which was added recently by bevyengine#4088
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@rparrett @ItsDoot
Clean up duplicated color conversion code (bevyengine#4360)
5330510 
# Objective

Cleans up some duplicated color -> u32 conversion code in `bevy_sprite` and `bevy_ui`

## Solution

Use `as_linear_rgba_u32` which was added recently by bevyengine#4088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@hymm hymm hymm approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rparrett @cart @hymm @mockersf