Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - add AnimationPlayer component only on scene roots that are also animation roots #4417

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - add AnimationPlayer component only on scene roots that are also animation roots #4417

wants to merge 3 commits into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Apr 4, 2022

Objective

Solution

  • Check all scene root nodes, and add the AnimationPlayer component to nodes that are also animation roots

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Apr 4, 2022
@cart cart added this to the Bevy 0.7 milestone Apr 4, 2022
@alice-i-cecile alice-i-cecile added A-Animation Make things move and change over time and removed S-Needs-Triage This issue needs to be labelled labels Apr 4, 2022
@mockersf mockersf added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Apr 4, 2022
@alice-i-cecile alice-i-cecile removed the S-Needs-Triage This issue needs to be labelled label Apr 4, 2022
alice-i-cecile
alice-i-cecile approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cart
cart reviewed Apr 5, 2022
View reviewed changes
crates/bevy_gltf/src/loader.rs Outdated Show resolved Hide resolved
@cart
Copy link
Member

cart commented Apr 5, 2022

bors r+

bors bot pushed a commit that referenced this pull request Apr 5, 2022
@mockersf
add AnimationPlayer component only on scene roots that are also anima…
30878e3 
…tion roots (#4417)

# Objective

- Fix #4416 
- The scene has two root nodes, with the second one being the animation root

## Solution

- Check all scene root nodes, and add the `AnimationPlayer` component to nodes that are also animation roots
@bors
Copy link
Contributor

bors bot commented Apr 5, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title add AnimationPlayer component only on scene roots that are also animation roots [Merged by Bors] - add AnimationPlayer component only on scene roots that are also animation roots Apr 5, 2022
@bors bors bot closed this Apr 5, 2022
aevyrie pushed a commit to aevyrie/bevy that referenced this pull request Jun 7, 2022
@mockersf @aevyrie
add AnimationPlayer component only on scene roots that are also anima…
909f439 
…tion roots (bevyengine#4417)

# Objective

- Fix bevyengine#4416 
- The scene has two root nodes, with the second one being the animation root

## Solution

- Check all scene root nodes, and add the `AnimationPlayer` component to nodes that are also animation roots
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
add AnimationPlayer component only on scene roots that are also anima…
a48f5d4 
…tion roots (bevyengine#4417)

# Objective

- Fix bevyengine#4416 
- The scene has two root nodes, with the second one being the animation root

## Solution

- Check all scene root nodes, and add the `AnimationPlayer` component to nodes that are also animation roots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart left review comments

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Animation Make things move and change over time C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
Bevy 0.7
Development

Successfully merging this pull request may close these issues.

Animation Player being placed on wrong entity when loading certain GLTF files
3 participants
@mockersf @cart @alice-i-cecile