-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - fix scene_viewer example on wasm #4426
Closed
jakobhellermann
wants to merge
2
commits into
bevyengine:main
from
jakobhellermann:scene-viewer-wasm
Closed
[Merged by Bors] - fix scene_viewer example on wasm #4426
jakobhellermann
wants to merge
2
commits into
bevyengine:main
from
jakobhellermann:scene-viewer-wasm
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobhellermann
added
C-Bug
An unexpected or incorrect behavior
C-Examples
An addition or correction to our examples
O-Web
Specific to web (WASM) builds
and removed
S-Needs-Triage
This issue needs to be labelled
labels
Apr 5, 2022
alice-i-cecile
approved these changes
Apr 5, 2022
I've had a similar issue with this |
mockersf
approved these changes
Apr 5, 2022
alice-i-cecile
approved these changes
Apr 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much cleaner. Good suggestion :)
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 5, 2022
The scene viewer example doesn't run on wasm because it sets the asset folder to `std::env::var("CARGO_MANIFEST_DIR").unwrap()`, which isn't supported on the web. Solution: set the asset folder to `"."` instead.
Build failed: |
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Apr 5, 2022
The scene viewer example doesn't run on wasm because it sets the asset folder to `std::env::var("CARGO_MANIFEST_DIR").unwrap()`, which isn't supported on the web. Solution: set the asset folder to `"."` instead.
bors
bot
changed the title
fix scene_viewer example on wasm
[Merged by Bors] - fix scene_viewer example on wasm
Apr 5, 2022
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
The scene viewer example doesn't run on wasm because it sets the asset folder to `std::env::var("CARGO_MANIFEST_DIR").unwrap()`, which isn't supported on the web. Solution: set the asset folder to `"."` instead.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
The scene viewer example doesn't run on wasm because it sets the asset folder to `std::env::var("CARGO_MANIFEST_DIR").unwrap()`, which isn't supported on the web. Solution: set the asset folder to `"."` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-Bug
An unexpected or incorrect behavior
C-Examples
An addition or correction to our examples
O-Web
Specific to web (WASM) builds
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scene viewer example doesn't run on wasm because it sets the asset folder to
std::env::var("CARGO_MANIFEST_DIR").unwrap()
, which isn't supported on the web.Solution: set the asset folder to
"."
instead.