Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - run examples on windows #4437

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - run examples on windows #4437

wants to merge 11 commits into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Apr 7, 2022 •
edited
Loading

Objective

  • Running examples on Linux in CI timeoutLinux is back!
  • But hey we can run examples on windows too!

Solution

  • Run examples on windows daily
  • I also added a 30 minutes timeout so that when it explodes, it doesn't explodes in 6 hours (the default timeout)
  • And simplified the linux examples by not requiring a custom feature set

IceSentry
IceSentry reviewed Apr 7, 2022
View reviewed changes
.github/workflows/ci.yml Outdated
- uses: actions/checkout@v3
- uses: actions/cache@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for not using cache on windows?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly because I have no ideas how folders are organised on windows

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's the case in the context of github runners, but as far as I know the paths in the linux run should be the same on windows. There's a ~ alias and windows supporst / so I think using the same paths should work.

@IceSentry IceSentry added the A-Build-System Related to build systems or continuous integration label Apr 7, 2022
@alice-i-cecile alice-i-cecile added the P-Critical This must be fixed immediately or contributors or users will be severely impacted label Apr 7, 2022
@alice-i-cecile
Copy link
Member

Added the Critical tag so we can merge things reliably. This LGTM (even if it is a bit of a hack), although I'm also curious about the cache.

@alice-i-cecile alice-i-cecile removed the P-Critical This must be fixed immediately or contributors or users will be severely impacted label Apr 7, 2022
@alice-i-cecile
Copy link
Member

CI is mysteriously unbroken again, see #4420. I still think we should consider making these changes, in order to reduce the possible points of failure.

@mockersf
Copy link
Member Author

mockersf commented Apr 7, 2022

I changed the PR to run examples on windows on a daily cron. It's still interesting to have the result, but not worth it to run it on every commit (and that way it'll be easy to copy/paste if there's a failure again)

IceSentry
IceSentry approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I wonder if there's other tests that could be moved to a daily only run to help make the PR pipeline faster. It's not a big issue and I guess at the speed we merge stuff it's better to make sure the PR is actually fully green.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 7, 2022
@alice-i-cecile
Copy link
Member

I wonder if there's other tests that could be moved to a daily only run

IMO we should try to run all of the examples daily on all platforms. I don't have a strong preference about whether that's done in this PR or a follow-up.

@DJMcNab
Copy link
Member

DJMcNab commented Apr 15, 2022

I suspect the examples should be run on the bors try/staging commits too, even if not run on every commit within a PR?

For example, being able to minimise windows on windows is both quite an important property to preserve, and apparently an easy property to lose. Without this test we can't ensure that PR authors maintain this property; only get a failure in the (as far as I know) low-visibility daily run.

@DJMcNab DJMcNab mentioned this pull request Apr 26, 2022
Closed
@mockersf
Copy link
Member Author

windows and iOS won't run on a commit/PR, but will run on a bors command

@mockersf
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Apr 27, 2022
@bors
Try #4437:
ba2aacc
@DJMcNab
Copy link
Member

DJMcNab commented Apr 27, 2022

Hopefully this try should fail, since #3597 should catch #4527

Unless you haven't rebased I guess, but it looks like you have

@bors
Copy link
Contributor

bors bot commented Apr 27, 2022

try

Build failed:

@mockersf
Copy link
Member Author

it failed on windows on the minimising example 🎉

@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request May 2, 2022
@mockersf
run examples on windows (#4437)
bc2624d 
# Objective

- ~~Running examples on Linux in CI timeout~~Linux is back!
- But hey we can run examples on windows too!

## Solution

- Run examples on windows daily
- I also added a 30 minutes timeout so that when it explodes, it doesn't explodes in 6 hours (the default timeout)
- And simplified the linux examples by not requiring a custom feature set
@bors
Copy link
Contributor

bors bot commented May 2, 2022

Build failed:

@alice-i-cecile
Copy link
Member

bors r-

@alice-i-cecile alice-i-cecile added the S-Blocked This cannot move forward until something else changes label May 2, 2022
@mockersf
Copy link
Member Author

mockersf commented May 2, 2022

blocked on #4527

@alice-i-cecile alice-i-cecile added the O-Windows Specific to the Windows desktop operating system label May 9, 2022
@mockersf
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request May 31, 2022
@bors
Try #4437:
74738f3
@bors
Copy link
Contributor

bors bot commented May 31, 2022

try

Build succeeded:

@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request May 31, 2022
@mockersf
run examples on windows (#4437)
27c321e 
# Objective

- ~~Running examples on Linux in CI timeout~~Linux is back!
- But hey we can run examples on windows too!

## Solution

- Run examples on windows daily
- I also added a 30 minutes timeout so that when it explodes, it doesn't explodes in 6 hours (the default timeout)
- And simplified the linux examples by not requiring a custom feature set
@bors
Copy link
Contributor

bors bot commented May 31, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title run examples on windows [Merged by Bors] - run examples on windows May 31, 2022
@bors bors bot closed this May 31, 2022
james7132 pushed a commit to james7132/bevy that referenced this pull request Jun 7, 2022
@mockersf @james7132
run examples on windows (bevyengine#4437)
9b7c40e 
# Objective

- ~~Running examples on Linux in CI timeout~~Linux is back!
- But hey we can run examples on windows too!

## Solution

- Run examples on windows daily
- I also added a 30 minutes timeout so that when it explodes, it doesn't explodes in 6 hours (the default timeout)
- And simplified the linux examples by not requiring a custom feature set
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
run examples on windows (bevyengine#4437)
44218f3 
# Objective

- ~~Running examples on Linux in CI timeout~~Linux is back!
- But hey we can run examples on windows too!

## Solution

- Run examples on windows daily
- I also added a 30 minutes timeout so that when it explodes, it doesn't explodes in 6 hours (the default timeout)
- And simplified the linux examples by not requiring a custom feature set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceSentry IceSentry IceSentry approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration O-Windows Specific to the Windows desktop operating system S-Blocked This cannot move forward until something else changes S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mockersf @alice-i-cecile @DJMcNab @IceSentry