-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Fix typos in Time::last_update
and Time::time_since_startup
documentation
#4470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Docs
An addition or correction to our documentation
A-Core
Common functionality for all bevy apps
and removed
S-Needs-Triage
This issue needs to be labelled
labels
Apr 13, 2022
alice-i-cecile
approved these changes
Apr 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
rparrett
approved these changes
Apr 13, 2022
tim-blackbird
approved these changes
Apr 13, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 13, 2022
…entation (#4470) # Objective The documentation of the `Time::last_update` and `Time::time_since_startup` methods contains typos. It uses apostrophe instead of backtick characters around `Instant` and `Duration`, so that these words are not recognized as identifiers in the generated API documentation. This should be fixed. ## Solution Fix the typos.
bors
bot
changed the title
Fix typos in
[Merged by Bors] - Fix typos in Apr 13, 2022
Time::last_update
and Time::time_since_startup
documentationTime::last_update
and Time::time_since_startup
documentation
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
…entation (bevyengine#4470) # Objective The documentation of the `Time::last_update` and `Time::time_since_startup` methods contains typos. It uses apostrophe instead of backtick characters around `Instant` and `Duration`, so that these words are not recognized as identifiers in the generated API documentation. This should be fixed. ## Solution Fix the typos.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…entation (bevyengine#4470) # Objective The documentation of the `Time::last_update` and `Time::time_since_startup` methods contains typos. It uses apostrophe instead of backtick characters around `Instant` and `Duration`, so that these words are not recognized as identifiers in the generated API documentation. This should be fixed. ## Solution Fix the typos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The documentation of the
Time::last_update
andTime::time_since_startup
methods contains typos. It uses apostrophe instead of backtick characters aroundInstant
andDuration
, so that these words are not recognized as identifiers in the generated API documentation. This should be fixed.Solution
Fix the typos.