Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - add timeout to miri job in CI #4743

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - add timeout to miri job in CI #4743

wants to merge 2 commits into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented May 14, 2022 •
edited
Loading

Objective

  • When Miri is failing, it can be very slow to do so

Screenshot 2022-05-14 at 03 05 40

Solution

  • Set the timeout for Miri to 60 minutes (it's 6 hours by default). It runs in around 10 minutes when successful
  • Fix cache key as it was set to the same as another task that doesn't build with the same parameters

@mockersf mockersf added the A-Build-System Related to build systems or continuous integration label May 14, 2022
@alice-i-cecile
Copy link
Member

I'd probably tune this to like 30 minutes, but I'm fine with this at 60.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 14, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request May 14, 2022
@mockersf
add timeout to miri job in CI (#4743)
947d3f9 
# Objective

- When Miri is failing, it can be very slow to do so

<img width="1397" alt="Screenshot 2022-05-14 at 03 05 40" src="https://user-images.githubusercontent.com/8672791/168405111-c5e27d63-7a5a-4a5e-b679-abbeeb3201d2.png">

## Solution

- Set the timeout for Miri to 60 minutes (it's 6 hours by default). It runs in around 10 minutes when successful
- Fix cache key as it was set to the same as another task that doesn't build with the same parameters
@bors
Copy link
Contributor

bors bot commented May 14, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title add timeout to miri job in CI [Merged by Bors] - add timeout to miri job in CI May 14, 2022
@bors bors bot closed this May 14, 2022
robtfm pushed a commit to robtfm/bevy that referenced this pull request May 17, 2022
@mockersf @robtfm
add timeout to miri job in CI (bevyengine#4743)
6c69ae2 
# Objective

- When Miri is failing, it can be very slow to do so

<img width="1397" alt="Screenshot 2022-05-14 at 03 05 40" src="https://user-images.githubusercontent.com/8672791/168405111-c5e27d63-7a5a-4a5e-b679-abbeeb3201d2.png">

## Solution

- Set the timeout for Miri to 60 minutes (it's 6 hours by default). It runs in around 10 minutes when successful
- Fix cache key as it was set to the same as another task that doesn't build with the same parameters
exjam pushed a commit to exjam/bevy that referenced this pull request May 22, 2022
@mockersf @exjam
add timeout to miri job in CI (bevyengine#4743)
42ed98a 
# Objective

- When Miri is failing, it can be very slow to do so

<img width="1397" alt="Screenshot 2022-05-14 at 03 05 40" src="https://user-images.githubusercontent.com/8672791/168405111-c5e27d63-7a5a-4a5e-b679-abbeeb3201d2.png">

## Solution

- Set the timeout for Miri to 60 minutes (it's 6 hours by default). It runs in around 10 minutes when successful
- Fix cache key as it was set to the same as another task that doesn't build with the same parameters
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
add timeout to miri job in CI (bevyengine#4743)
31fbf36 
# Objective

- When Miri is failing, it can be very slow to do so

<img width="1397" alt="Screenshot 2022-05-14 at 03 05 40" src="https://user-images.githubusercontent.com/8672791/168405111-c5e27d63-7a5a-4a5e-b679-abbeeb3201d2.png">

## Solution

- Set the timeout for Miri to 60 minutes (it's 6 hours by default). It runs in around 10 minutes when successful
- Fix cache key as it was set to the same as another task that doesn't build with the same parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @alice-i-cecile @james7132