Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PR template to encourage appropriate context in descriptions #4815

Closed
wants to merge 17 commits into from
Closed

Improve PR template to encourage appropriate context in descriptions #4815

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e554a96
Improve PR template to encourage appropriate context in descriptions
alice-i-cecile May 20, 2022
d71e823
Remove redundant Changelog section
alice-i-cecile May 20, 2022
044e7f3
Simplify language
alice-i-cecile May 20, 2022
f271d94
Fix typo
alice-i-cecile May 20, 2022
63451b7
Remove inaccurate line about RELEASES.md
alice-i-cecile May 20, 2022
e8df451
Remove line about draft PRs
alice-i-cecile May 20, 2022
52e6eef
Add advice on explicitly listing changes made
alice-i-cecile May 20, 2022
f11f6c7
Merge remote-tracking branch 'origin/better-pr-template' into better-…
alice-i-cecile May 20, 2022
5e87ad0
Edit for verbosity
alice-i-cecile May 20, 2022
8fc4cf9
Condense Objective and Context
alice-i-cecile May 20, 2022
447fd81
Be more explicit about who needs more background
alice-i-cecile May 20, 2022
99ab63a
Everyone needs context!
alice-i-cecile May 20, 2022
bdd4dcf
Typo fix
alice-i-cecile May 30, 2022
fb069a0
Remove extraneous words
alice-i-cecile May 30, 2022
2ce3a46
Discuss background -> Provide background
alice-i-cecile May 30, 2022
2d2816a
Mention CONTRIBUTING.md
alice-i-cecile Jun 4, 2022
55b1826
Typo
alice-i-cecile Jun 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,6 @@ Which parts of this PR were you unsure about? Which parts were particularly tric

If you're stuck on part of the changes or want feedback early, open a draft PR and list the items that need to be completed here using a checklist.

## Changelog

> This section is optional. If this was a trivial fix, or has no externally-visible impact, you can delete this section.

- What changed as a result of this PR?
- If applicable, organize changes under "Added", "Changed", or "Fixed" sub-headings
- Stick to one or two sentences. If more detail is needed for a particular change, consider adding it to the "Solution" section
- If you can't summarize the work, your change may be unreasonably large / unrelated. Consider splitting your PR to make it easier to review and merge!

alice-i-cecile marked this conversation as resolved.
Show resolved Hide resolved
## Migration Guide

> This section is optional. If there are no breaking changes, you can delete this section.
Expand Down