Implement WASM support for bevy_winit #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, replaced wasm_timer::Instant with instant::Instant as it is used by winit WASM implementation.
Moxinilian
added
C-Enhancement
|
Mmmm I love waking up to more wasm support :) |
|
Do you actually need cfg macros for |
|
I thought a bit about this before approving. Instant is actually just a type alias for std::Instant on native platforms. But not using the |
mrk-its
pushed a commit
to mrk-its/bevy
that referenced
this pull request
Oct 6, 2020
Also, replaced wasm_timer::Instant with instant::Instant as it is used by winit WASM implementation.
bors bot
pushed a commit
that referenced
this pull request
Sep 2, 2022
…n wasm. (#5863) # Objective #503 added these. I don't know what problem it solved, the PR doesn't say and the code didn't make it obvious to me. ## Solution AFAIK removing unsafe `Send`/`Sync` impls can't introduce unsoundness. Yeet. ## Migration Guide Why tho. Co-authored-by: devil-ira <justthecooldude@gmail.com>
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…n wasm. (bevyengine#5863) # Objective bevyengine#503 added these. I don't know what problem it solved, the PR doesn't say and the code didn't make it obvious to me. ## Solution AFAIK removing unsafe `Send`/`Sync` impls can't introduce unsoundness. Yeet. ## Migration Guide Why tho. Co-authored-by: devil-ira <justthecooldude@gmail.com>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…n wasm. (bevyengine#5863) # Objective bevyengine#503 added these. I don't know what problem it solved, the PR doesn't say and the code didn't make it obvious to me. ## Solution AFAIK removing unsafe `Send`/`Sync` impls can't introduce unsoundness. Yeet. ## Migration Guide Why tho. Co-authored-by: devil-ira <justthecooldude@gmail.com>
Subserial
pushed a commit
to Subserial/bevy_winit_hook
that referenced
this pull request
Jan 24, 2024
…n wasm. (#5863) # Objective bevyengine/bevy#503 added these. I don't know what problem it solved, the PR doesn't say and the code didn't make it obvious to me. ## Solution AFAIK removing unsafe `Send`/`Sync` impls can't introduce unsoundness. Yeet. ## Migration Guide Why tho. Co-authored-by: devil-ira <justthecooldude@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the rest of default plugins to build for
wasm32and twistsbevy_winitto run.The main problem is that winit Window is not Send + Sync, but since our WASM runtime is single threaded,
we can safely fake it.
Also, replaced wasm_timer::Instant with instant::Instant as it is used by winit WASM implementation, so the code won't duplicate.
To build the example use:
and modify
index.htmlto run it.