Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - remove component and resource suffixes from reflect structs #5219

Closed

Conversation

oliverpauffley
Copy link
Contributor

@oliverpauffley oliverpauffley commented Jul 5, 2022

Objective

Remove suffixes from reflect component and resource methods to closer match bevy norms. Fixes #5202

Solution

removed suffixes and also fixed a spelling error


Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) Thanks for the contribution!

@alice-i-cecile
Copy link
Member

Can you put the "Fixes" comment into your PR description? That will cause the issue to get linked and automatically closed.

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change labels Jul 6, 2022
@alice-i-cecile
Copy link
Member

Ping @Shatur for review.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jul 6, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jul 6, 2022
# Objective

Remove suffixes from reflect component and resource methods to closer match bevy norms.

## Solution

removed suffixes and also fixed a spelling error

---
@bors bors bot changed the title remove component and resource suffixes from reflect structs [Merged by Bors] - remove component and resource suffixes from reflect structs Jul 6, 2022
@bors bors bot closed this Jul 6, 2022
@oliverpauffley oliverpauffley deleted the remove-reflect-suffixes branch July 6, 2022 07:11
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
…ne#5219)

# Objective

Remove suffixes from reflect component and resource methods to closer match bevy norms.

## Solution

removed suffixes and also fixed a spelling error

---
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
…ne#5219)

# Objective

Remove suffixes from reflect component and resource methods to closer match bevy norms.

## Solution

removed suffixes and also fixed a spelling error

---
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
…ne#5219)

# Objective

Remove suffixes from reflect component and resource methods to closer match bevy norms.

## Solution

removed suffixes and also fixed a spelling error

---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not suffix methods with _component and _resource in reflected types.
4 participants