Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add assert_is_exclusive_system function #5275

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - Add assert_is_exclusive_system function #5275

wants to merge 6 commits into from

Conversation

MrPicklePinosaur
Copy link
Contributor

@MrPicklePinosaur MrPicklePinosaur commented Jul 10, 2022 •
edited
Loading

Add compile time check for if a system is an exclusive system. Resolves #4788

@alice-i-cecile
Copy link
Member

Thanks! Can you please:

  1. Add docs to match the other assert function.
  2. Use this in a pair of tests to make sure this works? Doc tests probably fit well here; one of them should fail to compile.

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Jul 10, 2022
DJMcNab
DJMcNab approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

I don't think (the other PR - thanks GitHub mobile for making me not confident enough my writing will be saved to go and fetch the number) is going to land anytime soon.

crates/bevy_ecs/src/system/mod.rs Outdated Show resolved Hide resolved
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jul 11, 2022
@alice-i-cecile
Copy link
Member

Passing on this for now due to low urgency; @MrPicklePinosaur can you address the nit?

MrPicklePinosaur and others added 2 commits July 13, 2022 17:01
@MrPicklePinosaur @tim-blackbird
Update crates/bevy_ecs/src/system/mod.rs
1d5bc91 
Co-authored-by: ira <JustTheCoolDude@gmail.com>
@MrPicklePinosaur
format
0698fee
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jul 13, 2022
@MrPicklePinosaur
Add assert_is_exclusive_system function (#5275)
c37dc8d 
Add compile time check for if a system is an exclusive system. Resolves #4788 

Co-authored-by: Daniel Liu <mr.picklepinosaur@gmail.com>
Co-authored-by: Daniel Liu <danieliu3120@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 13, 2022

Build failed:

@alice-i-cecile
Copy link
Member

bors retry

bors bot pushed a commit that referenced this pull request Jul 14, 2022
@MrPicklePinosaur
Add assert_is_exclusive_system function (#5275)
fe59fe5 
Add compile time check for if a system is an exclusive system. Resolves #4788 

Co-authored-by: Daniel Liu <mr.picklepinosaur@gmail.com>
Co-authored-by: Daniel Liu <danieliu3120@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 14, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add assert_is_exclusive_system function [Merged by Bors] - Add assert_is_exclusive_system function Jul 14, 2022
@bors bors bot closed this Jul 14, 2022
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
@MrPicklePinosaur @inodentry
Add assert_is_exclusive_system function (bevyengine#5275)
3c05b7f 
Add compile time check for if a system is an exclusive system. Resolves bevyengine#4788 

Co-authored-by: Daniel Liu <mr.picklepinosaur@gmail.com>
Co-authored-by: Daniel Liu <danieliu3120@gmail.com>
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@MrPicklePinosaur @james7132
Add assert_is_exclusive_system function (bevyengine#5275)
7a989ba 
Add compile time check for if a system is an exclusive system. Resolves bevyengine#4788 

Co-authored-by: Daniel Liu <mr.picklepinosaur@gmail.com>
Co-authored-by: Daniel Liu <danieliu3120@gmail.com>
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@MrPicklePinosaur @ItsDoot
Add assert_is_exclusive_system function (bevyengine#5275)
3375f8b 
Add compile time check for if a system is an exclusive system. Resolves bevyengine#4788 

Co-authored-by: Daniel Liu <mr.picklepinosaur@gmail.com>
Co-authored-by: Daniel Liu <danieliu3120@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-blackbird tim-blackbird tim-blackbird left review comments

@DJMcNab DJMcNab DJMcNab approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add assert_is_exclusive_system function
4 participants
@MrPicklePinosaur @alice-i-cecile @tim-blackbird @DJMcNab