[Merged by Bors] - Add associated constant IDENTITY to Transform and friends.
#5340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Transform
alice-i-cecile
approved these changes
Jul 16, 2022
|
while marking as deprecated is nice, at this stage of Bevy I would prefer to break directly |
Weibye
suggested changes
Aug 28, 2022
tim-blackbird
force-pushed
the
transform-identity
branch
from
19b6639
to
5d1c36e
Compare
Weibye
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Aug 28, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 30, 2022
# Objective Since `identity` is a const fn that takes no arguments it seems logical to make it an associated constant. This is also more in line with types from glam (eg. `Quat::IDENTITY`). ## Migration Guide The method `identity()` on `Transform`, `GlobalTransform` and `TransformBundle` has been deprecated. Use the associated constant `IDENTITY` instead. Co-authored-by: devil-ira <justthecooldude@gmail.com>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
IDENTITY to Transform and friends.IDENTITY to Transform and friends.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…ngine#5340) # Objective Since `identity` is a const fn that takes no arguments it seems logical to make it an associated constant. This is also more in line with types from glam (eg. `Quat::IDENTITY`). ## Migration Guide The method `identity()` on `Transform`, `GlobalTransform` and `TransformBundle` has been deprecated. Use the associated constant `IDENTITY` instead. Co-authored-by: devil-ira <justthecooldude@gmail.com>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…ngine#5340) # Objective Since `identity` is a const fn that takes no arguments it seems logical to make it an associated constant. This is also more in line with types from glam (eg. `Quat::IDENTITY`). ## Migration Guide The method `identity()` on `Transform`, `GlobalTransform` and `TransformBundle` has been deprecated. Use the associated constant `IDENTITY` instead. Co-authored-by: devil-ira <justthecooldude@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Since
identityis a const fn that takes no arguments it seems logical to make it an associated constant.This is also more in line with types from glam (eg.
Quat::IDENTITY).Migration Guide
The method
identity()onTransform,GlobalTransformandTransformBundlehas been deprecated.Use the associated constant
IDENTITYinstead.