Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix line material shader #5348

Closed
wants to merge 1 commit into from

Conversation

NiklasEi
Copy link
Member

@NiklasEi NiklasEi commented Jul 17, 2022

Objective

Solution

  • update the shader

@NiklasEi NiklasEi added the C-Examples An addition or correction to our examples label Jul 17, 2022
@superdump superdump added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Jul 17, 2022
@mockersf mockersf requested a review from IceSentry July 17, 2022 07:59
@mockersf
Copy link
Member

this examples was added in #5319 after the update to wgpu 0.13

@superdump
Copy link
Contributor

bors r+

bors bot pushed a commit that referenced this pull request Jul 17, 2022
# Objective

- The line shader missed the wgpu 0.13 update (#5168) and does not work in it's current state

## Solution

- update the shader
@superdump
Copy link
Contributor

I don't think a review from @IceSentry is necessary to wait for as the PR is only syntactical changes in WGSL, not functional changes in what the code does.

@bors
Copy link
Contributor

bors bot commented Jul 17, 2022

Build failed:

@mockersf
Copy link
Member

bors retry

bors bot pushed a commit that referenced this pull request Jul 17, 2022
# Objective

- The line shader missed the wgpu 0.13 update (#5168) and does not work in it's current state

## Solution

- update the shader
@bors
Copy link
Contributor

bors bot commented Jul 17, 2022

Build failed:

@superdump
Copy link
Contributor

bors retry

bors bot pushed a commit that referenced this pull request Jul 17, 2022
# Objective

- The line shader missed the wgpu 0.13 update (#5168) and does not work in it's current state

## Solution

- update the shader
@bors
Copy link
Contributor

bors bot commented Jul 17, 2022

Build failed:

@superdump
Copy link
Contributor

bors retry

bors bot pushed a commit that referenced this pull request Jul 17, 2022
# Objective

- The line shader missed the wgpu 0.13 update (#5168) and does not work in it's current state

## Solution

- update the shader
@bors
Copy link
Contributor

bors bot commented Jul 17, 2022

Build failed:

@superdump
Copy link
Contributor

bors retry

bors bot pushed a commit that referenced this pull request Jul 17, 2022
# Objective

- The line shader missed the wgpu 0.13 update (#5168) and does not work in it's current state

## Solution

- update the shader
@bors
Copy link
Contributor

bors bot commented Jul 17, 2022

Build failed:

@superdump
Copy link
Contributor

bors retry

bors bot pushed a commit that referenced this pull request Jul 17, 2022
# Objective

- The line shader missed the wgpu 0.13 update (#5168) and does not work in it's current state

## Solution

- update the shader
@bors bors bot changed the title Fix line material shader [Merged by Bors] - Fix line material shader Jul 17, 2022
@bors bors bot closed this Jul 17, 2022
@NiklasEi NiklasEi deleted the fix_line_material_shader branch July 17, 2022 16:24
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
# Objective

- The line shader missed the wgpu 0.13 update (bevyengine#5168) and does not work in it's current state

## Solution

- update the shader
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
# Objective

- The line shader missed the wgpu 0.13 update (bevyengine#5168) and does not work in it's current state

## Solution

- update the shader
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

- The line shader missed the wgpu 0.13 update (bevyengine#5168) and does not work in it's current state

## Solution

- update the shader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants