Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use FnOnce in Commands and ChildBuilder where possible #535

Merged
merged 2 commits into from
Sep 21, 2020
Merged

use FnOnce in Commands and ChildBuilder where possible #535

merged 2 commits into from
Sep 21, 2020

Conversation

HyperLightKitsune
Copy link
Contributor

resolves #531

Functions with_children and for_current_entity on Commands and ChildBuilder now take FnOnce rather than FnMut.

@Moxinilian Moxinilian added C-Code-Quality A section of code that is hard to understand or change A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible labels Sep 20, 2020
@HyperLightKitsune
Copy link
Contributor Author

Why is cargo fmt failing on CI but not on my local machine?

@HyperLightKitsune
Copy link
Contributor Author

Never mind, I was on the wrong branch.

@cart
Copy link
Member

cart commented Sep 21, 2020

Looks good to me. Thanks!

@cart cart merged commit 295e1f0 into bevyengine:master Sep 21, 2020
mrk-its pushed a commit to mrk-its/bevy that referenced this pull request Oct 6, 2020
@HyperLightKitsune @mrk-its
use FnOnce in Commands and ChildBuilder where possible (bevyengine#535)
7811526 
use FnOnce in Commands and ChildBuilder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change C-Feature A new feature, making something new possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

with_children takes a FnMut which prevents some use cases
3 participants
@HyperLightKitsune @cart @Moxinilian