Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Revert "Recalculate entity aabbs when meshes change (#4944)" #5489

Closed
wants to merge 1 commit into from

Conversation

cart
Copy link
Member

@cart cart commented Jul 29, 2022

Objective

Sadly, #4944 introduces a serious exponential despawn behavior, which cannot be included in 0.8. Handling AABBs properly is a controversial topic and one that deserves more time than the day we have left before release.

Solution

This reverts commit c2b332f.

@cart cart added the A-Rendering Drawing game state to the screen label Jul 29, 2022
@alice-i-cecile alice-i-cecile added the C-Performance A change motivated by improving speed, memory usage or compile times label Jul 29, 2022
@cart
Copy link
Member Author

cart commented Jul 29, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jul 29, 2022
# Objective

Sadly, #4944 introduces a serious exponential despawn behavior, which cannot be included in 0.8. [Handling AABBs properly is a controversial topic](#5423 (comment)) and one that deserves more time than the day we have left before release.

## Solution

This reverts commit c2b332f.
@bors bors bot changed the title Revert "Recalculate entity aabbs when meshes change (#4944)" [Merged by Bors] - Revert "Recalculate entity aabbs when meshes change (#4944)" Jul 29, 2022
@bors bors bot closed this Jul 29, 2022
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
bevyengine#5489)

# Objective

Sadly, bevyengine#4944 introduces a serious exponential despawn behavior, which cannot be included in 0.8. [Handling AABBs properly is a controversial topic](bevyengine#5423 (comment)) and one that deserves more time than the day we have left before release.

## Solution

This reverts commit c2b332f.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
bevyengine#5489)

# Objective

Sadly, bevyengine#4944 introduces a serious exponential despawn behavior, which cannot be included in 0.8. [Handling AABBs properly is a controversial topic](bevyengine#5423 (comment)) and one that deserves more time than the day we have left before release.

## Solution

This reverts commit c2b332f.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
bevyengine#5489)

# Objective

Sadly, bevyengine#4944 introduces a serious exponential despawn behavior, which cannot be included in 0.8. [Handling AABBs properly is a controversial topic](bevyengine#5423 (comment)) and one that deserves more time than the day we have left before release.

## Solution

This reverts commit c2b332f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Performance A change motivated by improving speed, memory usage or compile times
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants