Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix View by adding missing fields present in ViewUniform #5512

Closed
wants to merge 1 commit into from

Conversation

Azervu
Copy link
Contributor

@Azervu Azervu commented Jul 31, 2022

Objective

View mesh2d_view_types.wgsl was missing a couple of fields present in bevy::render::ViewUniform, causing rendering issues for shaders using later fields.

Solution

Solved by adding the fields in question

@superdump superdump added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Jul 31, 2022
@superdump
Copy link
Contributor

...oof. This should mean that Mesh2d is very broken in 0.8 unless I'm mistaken, or it's just luck that it isn't.

Copy link
Contributor

@superdump superdump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cart I think we have our first candidate for a point release. :/

@Azervu
Copy link
Contributor Author

Azervu commented Jul 31, 2022

That was quick, looks like the default rendering works because it only uses the first field.

@cart cart added this to the Bevy 0.8.1 milestone Jul 31, 2022
@cart
Copy link
Member

cart commented Jul 31, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jul 31, 2022
# Objective

View mesh2d_view_types.wgsl was missing a couple of fields present in bevy::render::ViewUniform, causing rendering issues for shaders using later fields.

## Solution
Solved by adding the fields in question
@bors bors bot changed the title Fix View by adding missing fields present in ViewUniform [Merged by Bors] - Fix View by adding missing fields present in ViewUniform Jul 31, 2022
@bors bors bot closed this Jul 31, 2022
bors bot pushed a commit that referenced this pull request Aug 5, 2022
# Objective

- Similar to #5512 , the `View` struct definition in the shaders in `bevy_sprite` and `bevy_ui` were out of sync with the rust-side `ViewUniform`. Only `view_proj` was being used and is the first member and as those shaders are not customisable it makes little difference in practice, unlike for `Mesh2d`.

## Solution

- Sync shader `View` struct definition in `bevy_sprite` and `bevy_ui` with the correct definition that matches `ViewUniform`
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
…5512)

# Objective

View mesh2d_view_types.wgsl was missing a couple of fields present in bevy::render::ViewUniform, causing rendering issues for shaders using later fields.

## Solution
Solved by adding the fields in question
cart pushed a commit that referenced this pull request Aug 19, 2022
# Objective

View mesh2d_view_types.wgsl was missing a couple of fields present in bevy::render::ViewUniform, causing rendering issues for shaders using later fields.

## Solution
Solved by adding the fields in question
cart pushed a commit that referenced this pull request Aug 19, 2022
# Objective

- Similar to #5512 , the `View` struct definition in the shaders in `bevy_sprite` and `bevy_ui` were out of sync with the rust-side `ViewUniform`. Only `view_proj` was being used and is the first member and as those shaders are not customisable it makes little difference in practice, unlike for `Mesh2d`.

## Solution

- Sync shader `View` struct definition in `bevy_sprite` and `bevy_ui` with the correct definition that matches `ViewUniform`
maccesch pushed a commit to Synphonyte/bevy that referenced this pull request Sep 28, 2022
# Objective

- Similar to bevyengine#5512 , the `View` struct definition in the shaders in `bevy_sprite` and `bevy_ui` were out of sync with the rust-side `ViewUniform`. Only `view_proj` was being used and is the first member and as those shaders are not customisable it makes little difference in practice, unlike for `Mesh2d`.

## Solution

- Sync shader `View` struct definition in `bevy_sprite` and `bevy_ui` with the correct definition that matches `ViewUniform`
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
…5512)

# Objective

View mesh2d_view_types.wgsl was missing a couple of fields present in bevy::render::ViewUniform, causing rendering issues for shaders using later fields.

## Solution
Solved by adding the fields in question
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
# Objective

- Similar to bevyengine#5512 , the `View` struct definition in the shaders in `bevy_sprite` and `bevy_ui` were out of sync with the rust-side `ViewUniform`. Only `view_proj` was being used and is the first member and as those shaders are not customisable it makes little difference in practice, unlike for `Mesh2d`.

## Solution

- Sync shader `View` struct definition in `bevy_sprite` and `bevy_ui` with the correct definition that matches `ViewUniform`
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
…5512)

# Objective

View mesh2d_view_types.wgsl was missing a couple of fields present in bevy::render::ViewUniform, causing rendering issues for shaders using later fields.

## Solution
Solved by adding the fields in question
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

- Similar to bevyengine#5512 , the `View` struct definition in the shaders in `bevy_sprite` and `bevy_ui` were out of sync with the rust-side `ViewUniform`. Only `view_proj` was being used and is the first member and as those shaders are not customisable it makes little difference in practice, unlike for `Mesh2d`.

## Solution

- Sync shader `View` struct definition in `bevy_sprite` and `bevy_ui` with the correct definition that matches `ViewUniform`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants