-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Remove unnecessary use
from examples
#5583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was added to prelude in bevyengine#5566
mockersf
approved these changes
Aug 5, 2022
tim-blackbird
approved these changes
Aug 5, 2022
alice-i-cecile
added
A-Rendering
Drawing game state to the screen
C-Examples
An addition or correction to our examples
C-Code-Quality
A section of code that is hard to understand or change
labels
Aug 6, 2022
bors r+ |
alice-i-cecile
added
the
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
label
Aug 6, 2022
bors bot
pushed a commit
that referenced
this pull request
Aug 6, 2022
# Objective `bevy::render::texture::ImageSettings` was added to prelude in #5566, so these `use` statements are unnecessary and the examples can be made a bit more concise. ## Solution Remove `use bevy::render::texture::ImageSettings`
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Remove unnecessary
[Merged by Bors] - Remove unnecessary Aug 6, 2022
use
from examplesuse
from examples
maccesch
pushed a commit
to Synphonyte/bevy
that referenced
this pull request
Sep 28, 2022
# Objective `bevy::render::texture::ImageSettings` was added to prelude in bevyengine#5566, so these `use` statements are unnecessary and the examples can be made a bit more concise. ## Solution Remove `use bevy::render::texture::ImageSettings`
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective `bevy::render::texture::ImageSettings` was added to prelude in bevyengine#5566, so these `use` statements are unnecessary and the examples can be made a bit more concise. ## Solution Remove `use bevy::render::texture::ImageSettings`
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective `bevy::render::texture::ImageSettings` was added to prelude in bevyengine#5566, so these `use` statements are unnecessary and the examples can be made a bit more concise. ## Solution Remove `use bevy::render::texture::ImageSettings`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Rendering
Drawing game state to the screen
C-Code-Quality
A section of code that is hard to understand or change
C-Examples
An addition or correction to our examples
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy::render::texture::ImageSettings
was added to prelude in #5566, so theseuse
statements are unnecessary and the examples can be made a bit more concise.Solution
Remove
use bevy::render::texture::ImageSettings