-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Windows as Entities #5589
Closed
Closed
Commits on Jan 18, 2023
-
Fix some CI and docs Fix links in docs Replacing `Window_id` with `Entity` Adding `WindowCommandsExtensions` for `Commands` Exploding `Window` into multiple coponents Adding `WindowCommands` to replace methods previously existing on `Window` Adding new `ExitCondition` Updating bevy_window to follow new pattern more Split `change_window` system into multiple system that handle `WindowCommand`s Start reworking `winit_runner()` Add initial sketch of example Adding notes Fully implement spawning of created window Start updating `bevy_render` to new patterns More cleanup of winit main loop minor fix And more tweaks continuing refactor of winit-loop Finish setting up components for new windows cleanup Start attempting to get rendering to compile again Updating `bevy_text` Fixing up `bevy_ui` Cleanup Fixing up `bevy_ui` fixing examples Fixing up more examples Every finally compiles! Fixing runtime bugs Wrangling with timing issues in render Window setup operations need to happen during build-time Further attempts at spawning components in build-time Using system-state apply Almost done with rebasing Fix up mis-merges Fix up event loop usage in winit Try to get multiple windows example to run, need to figure out some todos and such Migrate from using events to components with change detection Make system only create once Make sure to apply create window system state Clean up debug prints Some clean up of unused stuff and comments/debugging Fix up some examples/tests, more documentation, enums instead of marker components Some more clean up Just error on no primary window rather than panic Fix up rest of examples and tests Allow setting center position at runtime and consolidate positioning code Update minimized/maximized based on window state Fix up window state a bit, maybe figure out how to update it? Detect minimized window correctly Clean up getting entry to window map for winit Remove create window command example Fix rebasing mistakes and derive Resource for resources Add convenience method to WindowPosition for centering to a monitor Clean up unused imports Fix up ui focus, don't just give rid of stuff and fix imports Revert some mistakes in merging, clean up more imports Use derive instead of explicit impl for WindowFocus Rename field to window Adding more docs Fill inn the rest of the documentation Clean up multiple windows example Explain window bundle in multiple windows Remove TODOs for helpful panics, make all of the panics more helpful Add TODO for window independent UI Co-authored-by: Andreas Weibye <13300393+Weibye@users.noreply.github.com> Make extract_windodws private again Remove commented out unused code Use removal of window component to signal closing window, some clean up/renaming Simplify primary window closed system Fix up merging and update PR Tryin to fix up remaining errors Compiles again, maybe not entirely correct Try to figure out ordering issue with handle to winit not existing for rendering Fix extraction of windows Move despawning to PostUpdate because clear trackers is ran in Last Adding back canvas scaling Fixing wasm functionality Wasm now compiles correctly Add required platform-specific code Minor cleanup Make window canvas always on the window bundle so people don't need to do platform specific set up and it should Just Work TM Remove change for RemovedComponents Remove rebasing mess up Rename primary window to initial window Clean up examples a bit Use WindowPlugin for settings instead of mismerged WindowSettings Remove unnecessary added method Revert changes to ecs file Window reference stuff Revert "Rename primary window to initial window" This reverts commit 6ef86da. Normalize render target n stuff Trim excess filters Some more clean up Clean up comments More review feedback changes, revert mouse motion changes Doc comment for extracted window Update crates/bevy_ui/src/flex/mod.rs Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> Update examples/shader/post_processing.rs Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> Fix one mistaken extract Prevent some panicking Make WindowState a more write-only structure, since we can't really reflect whether the window is minimized or not Always on top component Re-apply cursor grab mode fixes Apply suggestions from code review Co-authored-by: Andreas Weibye <13300393+Weibye@users.noreply.github.com> Clean up some unused things Clean up a bit more bevy_window clean up Cargo fix a bunch of warnings Clean up exampe imports Initial hit test fall through component Revert cargo.toml and clean up Make always on top/hit test enums to better represent their toggle states Fix up examples around minimizing/hit test/always on top Don't panic if the last window is closed Clean up logging for window closing/opening Simplify is changed a bit by using a hashset instead of manually deduping Remove unnecessary primary window query from camera node Safety comment related to creating surface Gracefully handle closing windows more, some clean up Make exitting info more consistent across exit modes Clean up lifetimes on window component query Remove unnecessary zero resolution check, we don't detect minimization because it is too hard to tell what is considered minimized/occluded/etc. per platform Extra convenience method for resolution Clean up docs, fix ios example Remove 's bound for event writers Fix formatting Fix doc link to WindowBundle Remove partial eq derives so we don't accidentally compare things Fix clippy warnings Suppress clippy warning for too many arguments Improve documentation a bit Unify components into a single component for readability/discoverability Don't panic on no primary, just no surface Fix rendering with new unified component Fix up examples for unified component Comment for multiple windows example Fix up scale factor example Don't apply override when positioning the window Fix resizing of resolutions Clean up, fix remaining examples Unnecessary conversion in ui focus Clean up documentation, add docs for WindowState Docs for minimize/maximize constructors cargo check Map entities for WindowRef Clean up rebasing Formatting, emit WindowCreated event Fix up wasm stuff Revert unsupported changes Remove canvas swap testing Update examples/window/multiple_windows.rs Co-authored-by: Thierry Berger <contact@thierryberger.com> Clean up window state stuff so it works a bit more reliably Fix up wasm Remove unnecessary Component derives, add serialize Serialize for CursorIcon Cargo formatting ReflectSerialize behind flag Formatting again Fix up a bit of lints, unnecessary system state in redraw Fix ios example Unnecessary conversion Remove unnecessary import More unnecessary conversions More conversions Set requested resolution when resized as well Set logical resolution when setting physical Clean up logging Remove logical setting in resizing Apply suggestions from code review Co-authored-by: Andreas Weibye <13300393+Weibye@users.noreply.github.com> Rename set maximize by backend Remove requested width Builder method for scale factor override Some more convenience methods for resolutions Fix resizing examples
Configuration menu - View commit details
-
Copy full SHA for f2adf37 - Browse repository at this point
Copy the full SHA f2adf37View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9641d01 - Browse repository at this point
Copy the full SHA 9641d01View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb7c553 - Browse repository at this point
Copy the full SHA fb7c553View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57575f9 - Browse repository at this point
Copy the full SHA 57575f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 235a8f7 - Browse repository at this point
Copy the full SHA 235a8f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85bbeee - Browse repository at this point
Copy the full SHA 85bbeeeView commit details -
Configuration menu - View commit details
-
Copy full SHA for eb33c00 - Browse repository at this point
Copy the full SHA eb33c00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29cccfb - Browse repository at this point
Copy the full SHA 29cccfbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 87a12c3 - Browse repository at this point
Copy the full SHA 87a12c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40b134c - Browse repository at this point
Copy the full SHA 40b134cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c53ae75 - Browse repository at this point
Copy the full SHA c53ae75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22b0e9b - Browse repository at this point
Copy the full SHA 22b0e9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 266294a - Browse repository at this point
Copy the full SHA 266294aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e0b8bc - Browse repository at this point
Copy the full SHA 9e0b8bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 45c6c28 - Browse repository at this point
Copy the full SHA 45c6c28View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd7d414 - Browse repository at this point
Copy the full SHA dd7d414View commit details -
Configuration menu - View commit details
-
Copy full SHA for 022ca4a - Browse repository at this point
Copy the full SHA 022ca4aView commit details -
Try to avoid any funkiness with window managers by making sure we act…
…ually need to set fields
Configuration menu - View commit details
-
Copy full SHA for b0d5173 - Browse repository at this point
Copy the full SHA b0d5173View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c4ff0c - Browse repository at this point
Copy the full SHA 5c4ff0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for cbebdad - Browse repository at this point
Copy the full SHA cbebdadView commit details -
Configuration menu - View commit details
-
Copy full SHA for 831c488 - Browse repository at this point
Copy the full SHA 831c488View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e7d0fe - Browse repository at this point
Copy the full SHA 2e7d0feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 83fa3e2 - Browse repository at this point
Copy the full SHA 83fa3e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3f80cb - Browse repository at this point
Copy the full SHA e3f80cbView commit details
Commits on Jan 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2da4815 - Browse repository at this point
Copy the full SHA 2da4815View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.