Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - #5817: derive_bundle macro is not hygienic #5835

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - #5817: derive_bundle macro is not hygienic #5835

wants to merge 1 commit into from

Conversation

jgoday
Copy link
Contributor

@jgoday jgoday commented Aug 29, 2022 •
edited
Loading

Objective

Solution

Prepend :: to standard library full Vec qualified type name (::std::vec::Vec)

@jgoday jgoday mentioned this pull request Aug 29, 2022
Closed
@NathanSWard NathanSWard added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events labels Aug 29, 2022
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 29, 2022
@cart
Copy link
Member

cart commented Aug 30, 2022

bors r+

bors bot pushed a commit that referenced this pull request Aug 30, 2022
@jgoday
#5817: derive_bundle macro is not hygienic (#5835)
46f6816 
# Objective
- Fixes #5817.
- Removes std::vec::Vec ambiguities in derive_bundle macro

## Solution
Prepend :: to standard library full Vec qualified type name (::std::vec::Vec)
@bors
Copy link
Contributor

bors bot commented Aug 30, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title #5817: derive_bundle macro is not hygienic [Merged by Bors] - #5817: derive_bundle macro is not hygienic Aug 30, 2022
@bors bors bot closed this Aug 30, 2022
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@jgoday @james7132
bevyengine#5817: derive_bundle macro is not hygienic (bevyengine#5835)
8f77823 
# Objective
- Fixes bevyengine#5817.
- Removes std::vec::Vec ambiguities in derive_bundle macro

## Solution
Prepend :: to standard library full Vec qualified type name (::std::vec::Vec)
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@jgoday @ItsDoot
bevyengine#5817: derive_bundle macro is not hygienic (bevyengine#5835)
053c0e5 
# Objective
- Fixes bevyengine#5817.
- Removes std::vec::Vec ambiguities in derive_bundle macro

## Solution
Prepend :: to standard library full Vec qualified type name (::std::vec::Vec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanSWard NathanSWard NathanSWard approved these changes

@mockersf mockersf mockersf approved these changes

@derivator derivator derivator approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#[derive(Bundle)] is not hygienic
5 participants
@jgoday @cart @derivator @mockersf @NathanSWard