Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Miscellaneous code-quality improvements. #5860

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Miscellaneous code-quality improvements. #5860

wants to merge 4 commits into from

Conversation

tim-blackbird
Copy link
Contributor

Does what it do.

@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Sep 2, 2022
@alice-i-cecile
Copy link
Member

Agree with all of these changes; just needs a quick migration guide note for the breaking change.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Sep 5, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Sep 5, 2022
@tim-blackbird
Miscellaneous code-quality improvements. (#5860)
76ae6f4 
Does what it do.

Co-authored-by: devil-ira <justthecooldude@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 5, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Miscellaneous code-quality improvements. [Merged by Bors] - Miscellaneous code-quality improvements. Sep 5, 2022
@bors bors bot closed this Sep 5, 2022
@tim-blackbird tim-blackbird deleted the misc branch October 21, 2022 15:09
@IceSentry
Copy link
Contributor

Is there any reason why this was tagged Breaking-Change? I don't really see anything breaking in this PR.

@tim-blackbird
Copy link
Contributor Author

@IceSentry Alice thought the switch to IntoIterator was breaking. That conversation is resolved, but we forgot to remove the breaking change label.

@alice-i-cecile alice-i-cecile removed the M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Oct 25, 2022
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@tim-blackbird @james7132
Miscellaneous code-quality improvements. (bevyengine#5860)
0242937 
Does what it do.

Co-authored-by: devil-ira <justthecooldude@gmail.com>
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@tim-blackbird @ItsDoot
Miscellaneous code-quality improvements. (bevyengine#5860)
e00573b 
Does what it do.

Co-authored-by: devil-ira <justthecooldude@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanSWard NathanSWard NathanSWard requested changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@afonsolage afonsolage afonsolage approved these changes

Assignees
No one assigned
Labels
C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tim-blackbird @alice-i-cecile @IceSentry @afonsolage @NathanSWard