Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add getters and setters for InputAxis and ButtonSettings #6088

Closed
wants to merge 28 commits into from
Closed

[Merged by Bors] - Add getters and setters for InputAxis and ButtonSettings #6088

Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
73c1cd5
Getters and setters for AxisSettings
targrub Sep 24, 2022
d7fb8a5
Make Clippy happy
targrub Sep 24, 2022
b270766
AxisSettings setters return the new value rather than panicking
targrub Sep 24, 2022
2df74e7
Rename fields in AxisSettings
targrub Sep 24, 2022
d8a92cf
Validate button settings
targrub Sep 24, 2022
d6a56d7
Add ButtonSettings::new()
targrub Sep 24, 2022
17c2400
Add AxisSettings::new()
targrub Sep 24, 2022
12072d6
Move ButtonSettings doc comment from impl to struct
targrub Sep 24, 2022
efb85a7
Fix comparisons, default values for AxisSettings.
targrub Sep 24, 2022
ee4def4
Specify thiserror version as 1.0 rather than 1.0.30
targrub Sep 24, 2022
71a38fd
Merge branch 'bevyengine:main' into 3446branch
targrub Sep 24, 2022
6bb0687
Method should take &self, not &mut self.
targrub Sep 24, 2022
257880c
Use new access methods.
targrub Sep 24, 2022
d76e5cc
Update crates/bevy_input/src/gamepad.rs
targrub Sep 24, 2022
862aa94
Update crates/bevy_input/src/gamepad.rs
targrub Sep 29, 2022
983acac
Apply suggestions from code review
targrub Sep 29, 2022
1a58685
fmt --all fix
targrub Sep 29, 2022
9f79f30
Resurrected and edited old comment.
targrub Sep 29, 2022
35b8c9f
Proper return type for ButtonSettings::new() and test added for it.
targrub Oct 3, 2022
e6f8a24
Rejiggered the possible GamepadSettingsErrors. Docs improved.
targrub Oct 5, 2022
7effc59
Minor text change: One space after a period.
targrub Oct 5, 2022
be7682b
Merge branch 'bevyengine:main' into 3446branch
targrub Oct 5, 2022
e2ff931
Merge branch 'bevyengine:main' into 3446branch
targrub Oct 5, 2022
547866a
Better naming of GamepadSettingError enum variants.
targrub Oct 5, 2022
4e3e7de
Don't quote press and release thresholds.
targrub Oct 5, 2022
e93de78
Added docstrings for enum variants.
targrub Oct 5, 2022
213a79b
Separated out all AxisSettingError zone range violations
targrub Oct 5, 2022
ea94b67
Moved each docstring next to its enum variant.
targrub Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/bevy_input/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,4 @@ bevy_reflect = { path = "../bevy_reflect", version = "0.9.0-dev" }

# other
serde = { version = "1", features = ["derive"], optional = true }
thiserror = "1.0"
targrub marked this conversation as resolved.
Show resolved Hide resolved
Loading