-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Rename example file scaling.rs to ui_scaling.rs #6296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
approved these changes
Oct 19, 2022
james7132
added
C-Examples
An addition or correction to our examples
A-UI
Graphical user interfaces, styles, layouts, and widgets
labels
Oct 19, 2022
tim-blackbird
approved these changes
Oct 19, 2022
mockersf
approved these changes
Oct 19, 2022
mockersf
added
the
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
label
Oct 19, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 19, 2022
# Objective To be consistent like other examples, it's better to keep file name and example name same, so we don't need to find correct example name in Cargo.toml. ## Solution Rename example file scaling.rs to ui_scaling.rs.
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Rename example file scaling.rs to ui_scaling.rs
[Merged by Bors] - Rename example file scaling.rs to ui_scaling.rs
Oct 19, 2022
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective To be consistent like other examples, it's better to keep file name and example name same, so we don't need to find correct example name in Cargo.toml. ## Solution Rename example file scaling.rs to ui_scaling.rs.
Pietrek14
pushed a commit
to Pietrek14/bevy
that referenced
this pull request
Dec 17, 2022
# Objective To be consistent like other examples, it's better to keep file name and example name same, so we don't need to find correct example name in Cargo.toml. ## Solution Rename example file scaling.rs to ui_scaling.rs.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective To be consistent like other examples, it's better to keep file name and example name same, so we don't need to find correct example name in Cargo.toml. ## Solution Rename example file scaling.rs to ui_scaling.rs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-UI
Graphical user interfaces, styles, layouts, and widgets
C-Examples
An addition or correction to our examples
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
To be consistent like other examples, it's better to keep file name and example name same, so we don't need to find correct example name in Cargo.toml.
Solution
Rename example file scaling.rs to ui_scaling.rs.