Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Pipelined Rendering #6503

Closed
wants to merge 59 commits into from
Closed

[Merged by Bors] - Pipelined Rendering #6503

wants to merge 59 commits into from

Commits on Dec 15, 2022

  1. split sub app runner into 2 separate closures

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    3a648bc View commit details
    Browse the repository at this point in the history

  2. bad pipelining

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    115db67 View commit details
    Browse the repository at this point in the history

  3. fix issue with systems not running sometimes

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    833e47c View commit details
    Browse the repository at this point in the history

  4. create a global main thread executor

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    1bd4908 View commit details
    Browse the repository at this point in the history

  5. replace task scope executor with main thread executor

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    33f8207 View commit details
    Browse the repository at this point in the history

  6. reenable NonSendMarker on prepare_windows

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    1abddb8 View commit details
    Browse the repository at this point in the history

  7. make a safer abstraction for the main thread executor

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    ade5b77 View commit details
    Browse the repository at this point in the history

  8. try to fix ci 

    --still broken
    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    1e0cecc View commit details
    Browse the repository at this point in the history

  9. change scope to take a thread executor

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    5498fe5 View commit details
    Browse the repository at this point in the history

  10. add a test and update docs

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    d971288 View commit details
    Browse the repository at this point in the history

  11. fix wasm compilation 

    probably doesn't run correctly
    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    bbd8626 View commit details
    Browse the repository at this point in the history

  12. move extract after scope to make input processing closer to main app run

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    6842f4e View commit details
    Browse the repository at this point in the history

  13. switch to sending render world back and forth with channels

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    b6598fb View commit details
    Browse the repository at this point in the history

  14. add ability to disable pipelined rendering

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    0892f5b View commit details
    Browse the repository at this point in the history

  15. cleanup

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    dd9163c View commit details
    Browse the repository at this point in the history

  16. remove executor.run from scope

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    5d70b8d View commit details
    Browse the repository at this point in the history

  17. wrap scope so most uses don't need to pass None

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    dcd2d83 View commit details
    Browse the repository at this point in the history

  18. make a setup function on app to run the setup_rendering function

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    6e149e4 View commit details
    Browse the repository at this point in the history

  19. change pipelined rendering into a plugin

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    a53cb13 View commit details
    Browse the repository at this point in the history

  20. fix pipelined rendering

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    3cd2122 View commit details
    Browse the repository at this point in the history

  21. fix wasm again

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    799511f View commit details
    Browse the repository at this point in the history

  22. move setup to plugin

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    d306874 View commit details
    Browse the repository at this point in the history

  23. move cloning the MainThreadExecutor to setup

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    f2507fa View commit details
    Browse the repository at this point in the history

  24. remove runner and just run the schedule

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    8f5f259 View commit details
    Browse the repository at this point in the history

  25. fix headless example

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    1bf771c View commit details
    Browse the repository at this point in the history

  26. cleanup

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    c537afb View commit details
    Browse the repository at this point in the history

  27. add render app span

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    98e9c04 View commit details
    Browse the repository at this point in the history

  28. move inserting MainThreadExecutor to PipelinedRenderingPlugin

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    24241a4 View commit details
    Browse the repository at this point in the history

  29. remove unnecessary sync bound

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    a3b1929 View commit details
    Browse the repository at this point in the history

  30. change scope to not tick global executor when running parallel executor

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    32270e0 View commit details
    Browse the repository at this point in the history

  31. fix wasm

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    6e3837e View commit details
    Browse the repository at this point in the history

  32. move extract commands to render world

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    27d095c View commit details
    Browse the repository at this point in the history

  33. clean up

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    41b0cce View commit details
    Browse the repository at this point in the history

  34. use resource scope instead of removing resource

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    a4aa001 View commit details
    Browse the repository at this point in the history

  35. remove incorrect comment

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    45d8f00 View commit details
    Browse the repository at this point in the history

  36. fix wasm builds

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    c57257b View commit details
    Browse the repository at this point in the history

  37. fix rebase issues

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    883fe29 View commit details
    Browse the repository at this point in the history

  38. tick the task pool executor if there are no threads allocated

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    f506f74 View commit details
    Browse the repository at this point in the history

  39. call clear trackers on sub apps 

    see bevyengine#6878
    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    357549c View commit details
    Browse the repository at this point in the history

  40. remove unnecessary system and rename another

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    128de37 View commit details
    Browse the repository at this point in the history

  41. remove unnecessary dependency on bevy_tasks

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    cee9c53 View commit details
    Browse the repository at this point in the history

  42. run executors forever even with panics

    @hymm
    hymm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    e326796 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. Merge remote-tracking branch 'upstream/main' into maybe-pipelining

    @hymm
    hymm committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    0c993a9 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. Merge remote-tracking branch 'bevyengine/main' into maybe-pipelining

    @hymm
    hymm committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    c9f088e View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into maybe-pipelining

    @hymm
    hymm committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    d8425d6 View commit details
    Browse the repository at this point in the history

  3. fix some merge issues

    @hymm
    hymm committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    0fe7234 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. fix wasm build

    @hymm
    hymm committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    f3d5a0c View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
    @hymm @alice-i-cecile
    hymm and alice-i-cecile committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    8cf5e65 View commit details
    Browse the repository at this point in the history

  3. resolve some review comments

    @hymm
    hymm committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    47c5364 View commit details
    Browse the repository at this point in the history

  4. add example to subapp docs

    @hymm
    hymm committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    e4af50a View commit details
    Browse the repository at this point in the history

  5. fix ci

    @hymm
    hymm committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    a78ae52 View commit details
    Browse the repository at this point in the history

  6. refactor scope executors into separate functions

    @hymm
    hymm committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    39b636c View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. add tracing spans for all sub apps

    @hymm
    hymm committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    2f1c317 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2023

  1. Merge remote-tracking branch 'upstream/main' into maybe-pipelining

    @hymm
    hymm committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    b856cd7 View commit details
    Browse the repository at this point in the history

  2. change world.get_resource to resource 

    Co-authored-by: James Liu <contact@jamessliu.com>
    @hymm @james7132
    hymm and james7132 committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    92d123c View commit details
    Browse the repository at this point in the history

  3. add doc for tick_task_pool_executor

    @hymm
    hymm committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    1d6a5b9 View commit details
    Browse the repository at this point in the history

  4. fix spelling 

    Co-authored-by: James Liu <contact@jamessliu.com>
    @hymm @james7132
    hymm and james7132 committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    2faeb9b View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Robert Swain <robert.swain@gmail.com>
    @hymm @superdump
    hymm and superdump committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    04440d5 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. fix transmute

    @hymm
    hymm committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    0ebbde7 View commit details
    Browse the repository at this point in the history