Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Update old docs from Timer #6646

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Update old docs from Timer #6646

wants to merge 2 commits into from

Conversation

edgarssilva
Copy link
Contributor

When I was upgrading to 0.9 noticed there were some changes to the timer, mainly the TimerMode. When switching from the old is_repeating() and set_repeating() to the new mode() and set_mode() noticed the docs still had the old description.

When I was upgrading to 0.9 noticed there were some changes to the timer, mainly the `TimerMode`. 
When switching from the old `is_repeating()`  and `set_repeating()` to the new `mode()` and `set_mode()` noticed the docs still had the old description.
@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Time Involves time keeping and reporting labels Nov 16, 2022
@hymm hymm added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 17, 2022
@mockersf
Copy link
Member

a doc alias to "repeating" count be nice too 👍

@edgarssilva
Copy link
Contributor Author

a doc alias to "repeating" count be nice too 👍

Added a small commit, not sure if that's intended since it's my first time writing docs in rust and contributing to bevy.

Copy link
Member

@mockersf mockersf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for me, let's see what @alice-i-cecile thinks 🙂

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Nov 18, 2022
When I was upgrading to 0.9 noticed there were some changes to the timer, mainly the `TimerMode`.  When switching from the old `is_repeating()`  and `set_repeating()` to the new `mode()` and `set_mode()` noticed the docs still had the old description.
@bors bors bot changed the title Update old docs from Timer [Merged by Bors] - Update old docs from Timer Nov 18, 2022
@bors bors bot closed this Nov 18, 2022
taiyoungjang pushed a commit to taiyoungjang/bevy that referenced this pull request Dec 15, 2022
When I was upgrading to 0.9 noticed there were some changes to the timer, mainly the `TimerMode`.  When switching from the old `is_repeating()`  and `set_repeating()` to the new `mode()` and `set_mode()` noticed the docs still had the old description.
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
When I was upgrading to 0.9 noticed there were some changes to the timer, mainly the `TimerMode`.  When switching from the old `is_repeating()`  and `set_repeating()` to the new `mode()` and `set_mode()` noticed the docs still had the old description.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
When I was upgrading to 0.9 noticed there were some changes to the timer, mainly the `TimerMode`.  When switching from the old `is_repeating()`  and `set_repeating()` to the new `mode()` and `set_mode()` noticed the docs still had the old description.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Time Involves time keeping and reporting C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants