Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Update dead links in DefaultPlugins docs #6695

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Update dead links in DefaultPlugins docs #6695

wants to merge 1 commit into from

Conversation

chrisjuchem
Copy link
Contributor

Objective

Solution

  • Point links to the imported versions instead of the versions in external crates.

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Core Common functionality for all bevy apps labels Nov 19, 2022
@alice-i-cecile
Copy link
Member

Thanks! These links make much more sense.

Andrewp2
Andrewp2 approved these changes Nov 21, 2022
View reviewed changes
Copy link

@Andrewp2 Andrewp2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely :D

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 21, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Nov 21, 2022
@chrisjuchem
Update dead links in DefaultPlugins docs (#6695)
e2d1d9d 
# Objective

- Fix dead links on this docs page: https://docs.rs/bevy/0.9.0/bevy/struct.DefaultPlugins.html

## Solution

- Point links to the imported versions instead of the versions in external crates.
@bors
Copy link
Contributor

bors bot commented Nov 21, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Update dead links in DefaultPlugins docs [Merged by Bors] - Update dead links in DefaultPlugins docs Nov 21, 2022
@bors bors bot closed this Nov 21, 2022
taiyoungjang pushed a commit to taiyoungjang/bevy that referenced this pull request Dec 15, 2022
@chrisjuchem @taiyoungjang
Update dead links in DefaultPlugins docs (bevyengine#6695)
5f8f288 
# Objective

- Fix dead links on this docs page: https://docs.rs/bevy/0.9.0/bevy/struct.DefaultPlugins.html

## Solution

- Point links to the imported versions instead of the versions in external crates.
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@chrisjuchem @alradish
Update dead links in DefaultPlugins docs (bevyengine#6695)
4e75963 
# Objective

- Fix dead links on this docs page: https://docs.rs/bevy/0.9.0/bevy/struct.DefaultPlugins.html

## Solution

- Point links to the imported versions instead of the versions in external crates.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@chrisjuchem @ItsDoot
Update dead links in DefaultPlugins docs (bevyengine#6695)
49527c3 
# Objective

- Fix dead links on this docs page: https://docs.rs/bevy/0.9.0/bevy/struct.DefaultPlugins.html

## Solution

- Point links to the imported versions instead of the versions in external crates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@Andrewp2 Andrewp2 Andrewp2 approved these changes

Assignees
No one assigned
Labels
A-Core Common functionality for all bevy apps C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisjuchem @alice-i-cecile @Andrewp2