Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate the text alignment offset #6724

Closed
wants to merge 22 commits into from
Closed

Calculate the text alignment offset #6724

wants to merge 22 commits into from

Commits on Nov 22, 2022

  1. fixed extract_text_uinodes offset alignment bug

    @ickshonpe
    ickshonpe committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    e6d0947 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'bevyengine:main' into text-wrap-justify

    @ickshonpe
    ickshonpe committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    6775b48 View commit details
    Browse the repository at this point in the history

  3. Update crates/bevy_ui/src/render/mod.rs 

    Co-authored-by: François <mockersf@gmail.com>
    @ickshonpe @mockersf
    ickshonpe and mockersf committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    bcb16c0 View commit details
    Browse the repository at this point in the history

  4. Update mod.rs

    @ickshonpe
    ickshonpe committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    a1ec7ac View commit details
    Browse the repository at this point in the history

  5. cargo fmt --all

    @ickshonpe
    ickshonpe committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    6b9473a View commit details
    Browse the repository at this point in the history

  6. fix alignment offset being multiplied by scale twice

    @ickshonpe
    ickshonpe committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    feebad6 View commit details
    Browse the repository at this point in the history

  7. cargo fmt --all

    @ickshonpe
    ickshonpe committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    28efa7c View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2022

  1. removed the comment 

    "// NOTE: Should match `bevy_text::text2d::extract_text2d_sprite`"
    @ickshonpe
    ickshonpe committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    b7d9aa3 View commit details
    Browse the repository at this point in the history

  2. added text alignment example

    @ickshonpe
    ickshonpe committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    75a2d8c View commit details
    Browse the repository at this point in the history

  3. add example metadata

    @ickshonpe
    ickshonpe committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    9630c33 View commit details
    Browse the repository at this point in the history

  4. tiny cosmetic improvement

    @ickshonpe
    ickshonpe committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    3e1b211 View commit details
    Browse the repository at this point in the history

  5. cargo fmt -all

    @ickshonpe
    ickshonpe committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    8d7dfa3 View commit details
    Browse the repository at this point in the history

  6. fixes and formatting for example

    @ickshonpe
    ickshonpe committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    8334276 View commit details
    Browse the repository at this point in the history

  7. removed example

    @ickshonpe
    ickshonpe committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    ec8d739 View commit details
    Browse the repository at this point in the history

  8. simplified the example

    @ickshonpe
    ickshonpe committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    830a5dc View commit details
    Browse the repository at this point in the history

  9. remove scaling from example

    @ickshonpe
    ickshonpe committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    d6e736b View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2022

  1. Alignment_offset *does* need to multiplied by the scale factor.

    @ickshonpe
    ickshonpe committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    d111065 View commit details
    Browse the repository at this point in the history

  2. Multiply by ui_node.size() by the scale factor before calculating offset

    @ickshonpe
    ickshonpe committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    b9fb69c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'calculate-text-alignment' of https://github.com/ickshon… 

    …pe/bevy into calculate-text-alignment
    @ickshonpe
    ickshonpe committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    4bd17ef View commit details
    Browse the repository at this point in the history

  4. forgot to remove "* scale_factor"

    @ickshonpe
    ickshonpe committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    0a86a23 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2022

  1. simplified example

    @ickshonpe
    ickshonpe committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    7bb6e52 View commit details
    Browse the repository at this point in the history

  2. cargo fmt

    @ickshonpe
    ickshonpe committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    e7de76b View commit details
    Browse the repository at this point in the history