Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix an incorrect safety comment in World::get_resource #6764

Closed
wants to merge 1 commit into from

Conversation

JoJoJet
Copy link
Member

@JoJoJet JoJoJet commented Nov 26, 2022

Objective

Solution

  • Rewrite the safety comment to reflect the actual invariants being asserted.

@james7132 james7132 added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change labels Nov 26, 2022
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 27, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Nov 28, 2022
# Objective

* Fix #6307

## Solution

* Rewrite the safety comment to reflect the actual invariants being asserted.
@bors bors bot changed the title Fix an incorrect safety comment in World::get_resource [Merged by Bors] - Fix an incorrect safety comment in World::get_resource Nov 28, 2022
@bors bors bot closed this Nov 28, 2022
@JoJoJet JoJoJet deleted the resource-safety-comment branch November 28, 2022 15:34
taiyoungjang pushed a commit to taiyoungjang/bevy that referenced this pull request Dec 15, 2022
…6764)

# Objective

* Fix bevyengine#6307

## Solution

* Rewrite the safety comment to reflect the actual invariants being asserted.
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
…6764)

# Objective

* Fix bevyengine#6307

## Solution

* Rewrite the safety comment to reflect the actual invariants being asserted.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
…6764)

# Objective

* Fix bevyengine#6307

## Solution

* Rewrite the safety comment to reflect the actual invariants being asserted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

World::get_resource safety comment is incorrect
4 participants