Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Register Hash for glam types #6786

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Register Hash for glam types #6786

wants to merge 1 commit into from

Conversation

lewiszlw
Copy link
Member

Objective

Solution

  • Register Hash on all of glam's reflected integer vector types.

@alice-i-cecile alice-i-cecile added C-Usability A simple quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types A-Math Fundamental domain-agnostic mathematical operations labels Nov 28, 2022
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 28, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Nov 28, 2022
@lewiszlw
Register Hash for glam types (#6786)
0d833a3 
# Objective

- fixes #6736

## Solution

- Register `Hash` on all of glam's reflected integer vector types.
@bors
Copy link
Contributor

bors bot commented Nov 28, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Register Hash for glam types [Merged by Bors] - Register Hash for glam types Nov 28, 2022
@bors bors bot closed this Nov 28, 2022
@lewiszlw lewiszlw deleted the register-hash-for-glam-types branch November 28, 2022 15:25
@james7132 james7132 added this to the 0.10 milestone Dec 6, 2022
taiyoungjang pushed a commit to taiyoungjang/bevy that referenced this pull request Dec 15, 2022
@lewiszlw @taiyoungjang
Register Hash for glam types (bevyengine#6786)
0985d03 
# Objective

- fixes bevyengine#6736

## Solution

- Register `Hash` on all of glam's reflected integer vector types.
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@lewiszlw @alradish
Register Hash for glam types (bevyengine#6786)
91d8cdc 
# Objective

- fixes bevyengine#6736

## Solution

- Register `Hash` on all of glam's reflected integer vector types.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@lewiszlw @ItsDoot
Register Hash for glam types (bevyengine#6786)
17f96e1 
# Objective

- fixes bevyengine#6736

## Solution

- Register `Hash` on all of glam's reflected integer vector types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations A-Reflection Runtime information about types C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.

bevy_reflect: Register Hash for glam types
4 participants
@lewiszlw @alice-i-cecile @tim-blackbird @james7132