Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - set AVAILABLE_STORAGE_BUFFER_BINDINGS to the actual number of buffers available #6787

Conversation

mockersf
Copy link
Member

Objective

ERROR crates/bevy_render/src/render_resource/pipeline_cache.rs:660 failed to process shader: Unknown shader def: 'AVAILABLE_STORAGE_BUFFER_BINDINGS'

Solution

  • Fix it by always adding the shaderdef AVAILABLE_STORAGE_BUFFER_BINDINGS with the actual value, instead of 3 when 3 or more were available

@mockersf mockersf added A-Rendering Drawing game state to the screen O-Web Specific to web (WASM) builds C-Bug An unexpected or incorrect behavior labels Nov 28, 2022
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 28, 2022
@alice-i-cecile alice-i-cecile added this to the 0.9.1 milestone Nov 28, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Nov 28, 2022
… available (#6787)

# Objective

- Since #5900 3d examples fail in wasm
```
ERROR crates/bevy_render/src/render_resource/pipeline_cache.rs:660 failed to process shader: Unknown shader def: 'AVAILABLE_STORAGE_BUFFER_BINDINGS'
```

## Solution

- Fix it by always adding the shaderdef `AVAILABLE_STORAGE_BUFFER_BINDINGS` with the actual value, instead of 3 when 3 or more were available
@mockersf mockersf modified the milestones: 0.9.1, 0.10 Nov 28, 2022
@mockersf
Copy link
Member Author

this is not needed for the 0.9.1, #5900 won't go in the patch

@bors bors bot changed the title set AVAILABLE_STORAGE_BUFFER_BINDINGS to the actual number of buffers available [Merged by Bors] - set AVAILABLE_STORAGE_BUFFER_BINDINGS to the actual number of buffers available Nov 28, 2022
@bors bors bot closed this Nov 28, 2022
taiyoungjang pushed a commit to taiyoungjang/bevy that referenced this pull request Dec 15, 2022
… available (bevyengine#6787)

# Objective

- Since bevyengine#5900 3d examples fail in wasm
```
ERROR crates/bevy_render/src/render_resource/pipeline_cache.rs:660 failed to process shader: Unknown shader def: 'AVAILABLE_STORAGE_BUFFER_BINDINGS'
```

## Solution

- Fix it by always adding the shaderdef `AVAILABLE_STORAGE_BUFFER_BINDINGS` with the actual value, instead of 3 when 3 or more were available
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
… available (bevyengine#6787)

# Objective

- Since bevyengine#5900 3d examples fail in wasm
```
ERROR crates/bevy_render/src/render_resource/pipeline_cache.rs:660 failed to process shader: Unknown shader def: 'AVAILABLE_STORAGE_BUFFER_BINDINGS'
```

## Solution

- Fix it by always adding the shaderdef `AVAILABLE_STORAGE_BUFFER_BINDINGS` with the actual value, instead of 3 when 3 or more were available
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
… available (bevyengine#6787)

# Objective

- Since bevyengine#5900 3d examples fail in wasm
```
ERROR crates/bevy_render/src/render_resource/pipeline_cache.rs:660 failed to process shader: Unknown shader def: 'AVAILABLE_STORAGE_BUFFER_BINDINGS'
```

## Solution

- Fix it by always adding the shaderdef `AVAILABLE_STORAGE_BUFFER_BINDINGS` with the actual value, instead of 3 when 3 or more were available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior O-Web Specific to web (WASM) builds S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants