Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Improve code/comments for Ray::intersect_plane and its tests #6823

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Improve code/comments for Ray::intersect_plane and its tests #6823

wants to merge 2 commits into from

Conversation

tim-blackbird
Copy link
Contributor

@tim-blackbird tim-blackbird commented Dec 2, 2022 •
edited by bors bot
Loading

No description provided.

@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change A-Math Fundamental domain-agnostic mathematical operations labels Dec 3, 2022
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 3, 2022
@james7132 james7132 added this to the 0.10 milestone Dec 4, 2022
@cart
Copy link
Member

cart commented Dec 5, 2022

bors r+

bors bot pushed a commit that referenced this pull request Dec 5, 2022
@tim-blackbird
Improve code/comments for Ray::intersect_plane and its tests (#6823)
77c59c2 
Co-authored-by: devil-ira <justthecooldude@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 5, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Improve code/comments for Ray::intersect_plane and its tests [Merged by Bors] - Improve code/comments for Ray::intersect_plane and its tests Dec 5, 2022
@bors bors bot closed this Dec 5, 2022
@tim-blackbird tim-blackbird deleted the ray-fixes branch December 6, 2022 00:57
ickshonpe pushed a commit to ickshonpe/bevy that referenced this pull request Dec 6, 2022
@tim-blackbird @ickshonpe
Improve code/comments for Ray::intersect_plane and its tests (bevye…
3055af7 
…ngine#6823)

Co-authored-by: devil-ira <justthecooldude@gmail.com>
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@tim-blackbird @alradish
Improve code/comments for Ray::intersect_plane and its tests (bevye…
8f5cf05 
…ngine#6823)

Co-authored-by: devil-ira <justthecooldude@gmail.com>
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@tim-blackbird @ItsDoot
Improve code/comments for Ray::intersect_plane and its tests (bevye…
7f44f54 
…ngine#6823)

Co-authored-by: devil-ira <justthecooldude@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.
5 participants
@tim-blackbird @cart @alice-i-cecile @mockersf @james7132