Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Update an outdated example for Mut::map_unchanged #7115

Closed
wants to merge 2 commits into from

Conversation

JoJoJet
Copy link
Member

@JoJoJet JoJoJet commented Jan 6, 2023

Objective

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-ECS Entities, components, systems, and events labels Jan 6, 2023
@JoJoJet JoJoJet added C-Code-Quality A section of code that is hard to understand or change and removed A-ECS Entities, components, systems, and events labels Jan 6, 2023
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed C-Code-Quality A section of code that is hard to understand or change labels Jan 6, 2023
@mockersf
Copy link
Member

mockersf commented Jan 6, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jan 6, 2023
# Objective

- The doctest for `Mut::map_unchanged` uses a fake function `set_if_not_equal` to demonstrate usage.
- Now that #6853 has been merged, we can use `Mut::set_if_neq` directly instead of mocking it.
@bors bors bot changed the title Update an outdated example for Mut::map_unchanged [Merged by Bors] - Update an outdated example for Mut::map_unchanged Jan 6, 2023
@bors bors bot closed this Jan 6, 2023
@JoJoJet JoJoJet deleted the map-unchanged-update branch January 6, 2023 23:45
james7132 pushed a commit to james7132/bevy that referenced this pull request Jan 21, 2023
# Objective

- The doctest for `Mut::map_unchanged` uses a fake function `set_if_not_equal` to demonstrate usage.
- Now that bevyengine#6853 has been merged, we can use `Mut::set_if_neq` directly instead of mocking it.
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
# Objective

- The doctest for `Mut::map_unchanged` uses a fake function `set_if_not_equal` to demonstrate usage.
- Now that bevyengine#6853 has been merged, we can use `Mut::set_if_neq` directly instead of mocking it.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

- The doctest for `Mut::map_unchanged` uses a fake function `set_if_not_equal` to demonstrate usage.
- Now that bevyengine#6853 has been merged, we can use `Mut::set_if_neq` directly instead of mocking it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants