-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Update an outdated example for Mut::map_unchanged
#7115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Jan 6, 2023
alice-i-cecile
added
C-Docs
An addition or correction to our documentation
A-ECS
Entities, components, systems, and events
labels
Jan 6, 2023
JoJoJet
added
C-Code-Quality
A section of code that is hard to understand or change
and removed
A-ECS
Entities, components, systems, and events
labels
Jan 6, 2023
alice-i-cecile
added
A-ECS
Entities, components, systems, and events
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
and removed
C-Code-Quality
A section of code that is hard to understand or change
labels
Jan 6, 2023
mockersf
approved these changes
Jan 6, 2023
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 6, 2023
# Objective - The doctest for `Mut::map_unchanged` uses a fake function `set_if_not_equal` to demonstrate usage. - Now that #6853 has been merged, we can use `Mut::set_if_neq` directly instead of mocking it.
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
Update an outdated example for
[Merged by Bors] - Update an outdated example for Jan 6, 2023
Mut::map_unchanged
Mut::map_unchanged
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Jan 21, 2023
# Objective - The doctest for `Mut::map_unchanged` uses a fake function `set_if_not_equal` to demonstrate usage. - Now that bevyengine#6853 has been merged, we can use `Mut::set_if_neq` directly instead of mocking it.
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective - The doctest for `Mut::map_unchanged` uses a fake function `set_if_not_equal` to demonstrate usage. - Now that bevyengine#6853 has been merged, we can use `Mut::set_if_neq` directly instead of mocking it.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - The doctest for `Mut::map_unchanged` uses a fake function `set_if_not_equal` to demonstrate usage. - Now that bevyengine#6853 has been merged, we can use `Mut::set_if_neq` directly instead of mocking it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-ECS
Entities, components, systems, and events
C-Docs
An addition or correction to our documentation
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Mut::map_unchanged
uses a fake functionset_if_not_equal
to demonstrate usage.set_if_neq
method toDetectChanges
trait (Rebased) #6853 has been merged, we can useMut::set_if_neq
directly instead of mocking it.