Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add wrapping_add to change_tick #7146

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Add wrapping_add to change_tick #7146

wants to merge 1 commit into from

Conversation

Tirthnp
Copy link
Contributor

@Tirthnp Tirthnp commented Jan 10, 2023

Objective

Fixes #7140

Solution

As discussed in the issue, added wrapping_add

@Tirthnp Tirthnp changed the title Add wrapping_add to change_tick #7140 Add wrapping_add to change_tick Jan 10, 2023
alice-i-cecile
alice-i-cecile approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events labels Jan 10, 2023
@alice-i-cecile alice-i-cecile added this to the 0.10 milestone Jan 10, 2023
@hymm hymm added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 10, 2023
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jan 10, 2023
@Tirthnp
Add wrapping_add to change_tick (#7146)
a207178 
# Objective

Fixes #7140


## Solution

As discussed in the issue, added wrapping_add

---
@bors
Copy link
Contributor

bors bot commented Jan 10, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add wrapping_add to change_tick [Merged by Bors] - Add wrapping_add to change_tick Jan 10, 2023
@bors bors bot closed this Jan 10, 2023
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@Tirthnp @alradish
Add wrapping_add to change_tick (bevyengine#7146)
676982c 
# Objective

Fixes bevyengine#7140


## Solution

As discussed in the issue, added wrapping_add

---
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@Tirthnp @ItsDoot
Add wrapping_add to change_tick (bevyengine#7146)
744c488 
# Objective

Fixes bevyengine#7140


## Solution

As discussed in the issue, added wrapping_add

---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hymm hymm hymm approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

@maniwani maniwani Awaiting requested review from maniwani

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.

Panic: add with overflow in exclusive function system
4 participants
@Tirthnp @alice-i-cecile @hymm @mockersf