Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Change default FocusPolicy to Pass #7161

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Change default FocusPolicy to Pass #7161

wants to merge 3 commits into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Jan 11, 2023 •
edited
Loading

Objective

  • While building UI, it makes more sense for most nodes to have a FocusPolicy of Pass, so that user interaction can correctly bubble
  • Only ButtonBundle blocks by default

This change means that for someone adding children to a button, it's not needed to change the focus policy of those children to Pass for the button to continue to work.

Changelog

  • FocusPolicy default has changed from FocusPolicy::Block to FocusPolicy::Pass

Migration Guide

  • FocusPolicy default has changed from FocusPolicy::Block to FocusPolicy::Pass

@mockersf mockersf added A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A simple quality-of-life change that makes Bevy easier to use C-Breaking-Change A breaking change to Bevy's public API that needs to be noted in a migration guide labels Jan 11, 2023
@IceSentry
Copy link
Contributor

Could you copy the Changelog in a Migration Guide block? It makes my automated tool to generate migration guide much easier if the section is present.

alice-i-cecile
alice-i-cecile approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set_if_neq doing its job :D

bors r+

bors bot pushed a commit that referenced this pull request Jan 12, 2023
@mockersf
Change default FocusPolicy to Pass (#7161)
ba3069f 
# Objective

- While building UI, it makes more sense for most nodes to have a `FocusPolicy` of `Pass`, so that user interaction can correctly bubble
- Only `ButtonBundle` blocks by default

This change means that for someone adding children to a button, it's not needed to change the focus policy of those children to `Pass` for the button to continue to work.

---

## Changelog

- `FocusPolicy` default has changed from `FocusPolicy::Block` to `FocusPolicy::Pass`

## Migration Guide

- `FocusPolicy` default has changed from `FocusPolicy::Block` to `FocusPolicy::Pass`
@bors
Copy link
Contributor

bors bot commented Jan 12, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Change default FocusPolicy to Pass [Merged by Bors] - Change default FocusPolicy to Pass Jan 12, 2023
@bors bors bot closed this Jan 12, 2023
@james7132 james7132 mentioned this pull request Jan 17, 2023
Closed
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@mockersf @alradish
Change default FocusPolicy to Pass (bevyengine#7161)
c3ff5f7 
# Objective

- While building UI, it makes more sense for most nodes to have a `FocusPolicy` of `Pass`, so that user interaction can correctly bubble
- Only `ButtonBundle` blocks by default

This change means that for someone adding children to a button, it's not needed to change the focus policy of those children to `Pass` for the button to continue to work.

---

## Changelog

- `FocusPolicy` default has changed from `FocusPolicy::Block` to `FocusPolicy::Pass`

## Migration Guide

- `FocusPolicy` default has changed from `FocusPolicy::Block` to `FocusPolicy::Pass`
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
Change default FocusPolicy to Pass (bevyengine#7161)
562696f 
# Objective

- While building UI, it makes more sense for most nodes to have a `FocusPolicy` of `Pass`, so that user interaction can correctly bubble
- Only `ButtonBundle` blocks by default

This change means that for someone adding children to a button, it's not needed to change the focus policy of those children to `Pass` for the button to continue to work.

---

## Changelog

- `FocusPolicy` default has changed from `FocusPolicy::Block` to `FocusPolicy::Pass`

## Migration Guide

- `FocusPolicy` default has changed from `FocusPolicy::Block` to `FocusPolicy::Pass`
@soerenmeier soerenmeier mentioned this pull request Mar 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@IceSentry IceSentry IceSentry approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Breaking-Change A breaking change to Bevy's public API that needs to be noted in a migration guide C-Usability A simple quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @IceSentry @alice-i-cecile