Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Relative cursor position #7199
[Merged by Bors] - Relative cursor position #7199
Changes from 13 commits
71056a3
d607e6b
83f2417
6da0e41
3500039
d823b1b
f68eb33
6ed303e
23a22ae
a27f8b1
8513317
a81cb5a
0921e75
42699d1
ae57369
3ddd0c0
2b64fa6
9713cc8
32cde9a
b52f950
6a00611
b5d915e
2462874
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should all node-bundles with some form of interaction have this component as default? I think it would make sense on the
ButtonBundle
at the very least. @alice-i-cecile, thoughts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that it's necessary. If someone needs this functionality they can always insert the component themselves, but I imagine most people won't use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, having thought about it a bit more, it only makes sense to add this to "default" bundles when we are building some more functionality on top of this and that is a requirement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, we should only add components to bundles when they have a built-in use.