Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wavy text #725

Merged
merged 4 commits into from
Oct 30, 2020
Merged

fix wavy text #725

merged 4 commits into from
Oct 30, 2020

Conversation

tigregalis
Copy link
Contributor

Addresses #283

Quick fix for wavy text.

You can see the difference in the "ing" in "Nothing".

Before
image

After
image

Here is what it looks like in Word for reference:
image

@karroffel karroffel added C-Bug An unexpected or incorrect behavior A-UI Graphical user interfaces, styles, layouts, and widgets labels Oct 24, 2020
@cart
Copy link
Member

cart commented Oct 29, 2020

This does fix the waviness, but it also introduces a noticeable y-offset:

(left is master right is this pr)
image

Off the top of my head, idk which one is correct. It also looks like you dont have those offsets in your images? Maybe its a windows vs linux thing?

@cart
Copy link
Member

cart commented Oct 30, 2020

I'm getting the same y-offset on all platforms. Did you manually offset the text in your screenshots to account for this?

crates/bevy_text/src/draw.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants