[Merged by Bors] - Make the many_foxes plane smaller to fix shadow issues. #7339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Jan 23, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
JMS55
approved these changes
Jan 23, 2023
mockersf
approved these changes
Jan 23, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 23, 2023
# Objective Shadows are broken on many_foxes on AMD GPUs. This seems to be due to rounding or floating point precision issues combined with the absolute unit of a plane that it's currently using. Related: #6542 I'm not sure if we want to close that issue, as there's still the underlying issue of shadows breaking on overly large planes. ## Solution Make the plane smaller.
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
) # Objective Shadows are broken on many_foxes on AMD GPUs. This seems to be due to rounding or floating point precision issues combined with the absolute unit of a plane that it's currently using. Related: bevyengine#6542 I'm not sure if we want to close that issue, as there's still the underlying issue of shadows breaking on overly large planes. ## Solution Make the plane smaller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Shadows are broken on many_foxes on AMD GPUs. This seems to be due to rounding or floating point precision issues combined with the absolute unit of a plane that it's currently using.
Related: #6542
I'm not sure if we want to close that issue, as there's still the underlying issue of shadows breaking on overly large planes.
Solution
Make the plane smaller.