Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use embedded glslang for runtime glsl-to-spirv #740

Merged
merged 6 commits into from
Nov 3, 2020

Conversation

PrototypeNM1
Copy link
Contributor

@PrototypeNM1 PrototypeNM1 commented Oct 28, 2020

Depends on cart/glsl-to-spirv#1
Dependent of #86

This commit adds runtime glsl-to-spriv support to Bevy and opens the door for Android builds without needing to setup anything beyond normal Android NDK environment variables.

@PrototypeNM1
Copy link
Contributor Author

Special thanks to @enfipy for assisting in debugging linker issues.

@PrototypeNM1 PrototypeNM1 mentioned this pull request Oct 28, 2020
@memoryruins memoryruins added O-Android Specific to the Android mobile operating system A-Rendering Drawing game state to the screen labels Oct 28, 2020
@cart
Copy link
Member

cart commented Oct 29, 2020

Looking now / testing on as many platforms as I can.

@enfipy
Copy link
Contributor

enfipy commented Oct 29, 2020

Tested on Android 8 with MiUi - it works well.
But I think @PrototypeNM1 forgot to add an update for glsl-to-spirv (or it should be merged to bevy-glsl-to-spirv first).

@cart cart merged commit 53c4c45 into bevyengine:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen O-Android Specific to the Android mobile operating system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants