Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add constructor new to ArrayIter #7449

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Add constructor new to ArrayIter #7449

wants to merge 3 commits into from

Conversation

elbertronnie
Copy link
Contributor

Objective

Solution

  • Changed fields of ArrayIter to be private.
  • Add a constructor new to ArrayIter.
  • Replace normal struct creation with new.

Changelog

  • Add a constructor new to ArrayIter.

@james7132 james7132 added A-Reflection Runtime information about types C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Jan 31, 2023
MrGVSV
MrGVSV approved these changes Jan 31, 2023
View reviewed changes
crates/bevy_reflect/src/array.rs Outdated Show resolved Hide resolved
@MrGVSV MrGVSV added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 31, 2023
@elbertronnie @MrGVSV
Remove extra docs
5f2fcc7 
Co-authored-by: Gino Valente <49806985+MrGVSV@users.noreply.github.com>
@james7132
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jan 31, 2023
@elbertronnie
Add constructor new to ArrayIter (#7449)
615d3d2 
# Objective

- Fixes #7430.

## Solution

- Changed fields of `ArrayIter` to be private.
- Add a constructor `new` to `ArrayIter`.
- Replace normal struct creation with `new`.

---

## Changelog

- Add a constructor `new` to `ArrayIter`.


Co-authored-by: Elbert Ronnie <103196773+elbertronnie@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Jan 31, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add constructor new to ArrayIter [Merged by Bors] - Add constructor new to ArrayIter Jan 31, 2023
@bors bors bot closed this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinerSebas MinerSebas MinerSebas left review comments

@MrGVSV MrGVSV MrGVSV approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-Reflection Runtime information about types C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Reflection
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bevy_reflect: Array cannot be fully implemented on user-defined types
5 participants
@elbertronnie @james7132 @tim-blackbird @MrGVSV @MinerSebas