Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - remove unused var in fxaa shader #7509

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - remove unused var in fxaa shader #7509

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Feb 5, 2023

Objective

  • There is an unused var
  • Removing it doesn't seem to break anything

Solution

  • Remove it

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change labels Feb 6, 2023
alice-i-cecile
alice-i-cecile approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Feb 6, 2023
@mockersf
remove unused var in fxaa shader (#7509)
1c9b1b4 
# Objective

- There is an unused var
- Removing it doesn't seem to break anything

## Solution

- Remove it
@bors
Copy link
Contributor

bors bot commented Feb 6, 2023

Build failed:

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 6, 2023
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 6, 2023
@mockersf
remove unused var in fxaa shader (#7509)
9adffb7 
# Objective

- There is an unused var
- Removing it doesn't seem to break anything

## Solution

- Remove it
@bors
Copy link
Contributor

bors bot commented Feb 6, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title remove unused var in fxaa shader [Merged by Bors] - remove unused var in fxaa shader Feb 6, 2023
@bors bors bot closed this Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@torsteingrindvik torsteingrindvik torsteingrindvik approved these changes

@oCaioOliveira oCaioOliveira oCaioOliveira approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mockersf @alice-i-cecile @torsteingrindvik @oCaioOliveira