Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Rename schedule v3 to schedule #7519

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Rename schedule v3 to schedule #7519

wants to merge 4 commits into from

Conversation

lewiszlw
Copy link
Member

@lewiszlw lewiszlw commented Feb 6, 2023

Objective

Solution

  • Rename schedule_v3 to schedule
  • Suppress "module inception" lint

@alice-i-cecile alice-i-cecile added this to the 0.10 milestone Feb 6, 2023
alice-i-cecile
alice-i-cecile approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still prefer scheduling, but I'll live with this :p

Thanks for doing this for us!

james7132
james7132 reviewed Feb 6, 2023
View reviewed changes
tools/ci/src/main.rs Outdated Show resolved Hide resolved
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 6, 2023
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change labels Feb 6, 2023
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 6, 2023
@lewiszlw
Rename schedule v3 to schedule (#7519)
a2e1d89 
# Objective

- Follow up of #7267

## Solution

- Rename schedule_v3 to schedule
- Suppress "module inception" lint
@bors
Copy link
Contributor

bors bot commented Feb 6, 2023

Build failed:

@alice-i-cecile alice-i-cecile mentioned this pull request Feb 6, 2023
Closed
@james7132
Copy link
Member

bors retry

bors bot pushed a commit that referenced this pull request Feb 6, 2023
@lewiszlw
Rename schedule v3 to schedule (#7519)
aa4170d 
# Objective

- Follow up of #7267

## Solution

- Rename schedule_v3 to schedule
- Suppress "module inception" lint
@bors
Copy link
Contributor

bors bot commented Feb 6, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Rename schedule v3 to schedule [Merged by Bors] - Rename schedule v3 to schedule Feb 6, 2023
@bors bors bot closed this Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 left review comments

@hymm hymm hymm left review comments

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Scheduling
Archived in project
Milestone
0.10
Development

Successfully merging this pull request may close these issues.
5 participants
@lewiszlw @alice-i-cecile @james7132 @hymm @mockersf